From: Seung-Woo Kim <sw0312.kim@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media <linux-media@vger.kernel.org>,
Kamil Debski <k.debski@samsung.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment
Date: Thu, 06 Mar 2014 11:13:08 +0900 [thread overview]
Message-ID: <5317D9B4.1080405@samsung.com> (raw)
In-Reply-To: <CAK9yfHx_yx9qvitSGfNZWJfRK1ZtrOu3VdhJh-aEZ4LNv_8Z-A@mail.gmail.com>
Hello Sachin,
On 2014년 03월 05일 20:42, Sachin Kamat wrote:
> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
(...)
>> - dev->bank1 = dev->bank1;
>
> Are you sure this isn't some kind of typo? If not then your commit
> description is too verbose
> to actually say that the code is redundant and could be removed. The
> code here is something like
>
> a = a;
>
> which does not make sense nor add any value and hence redundant and
> could be removed.
Right, this meaningless code can be simply removed as like the first
version. Anyway this redundant made from change of address type in
earlier patch. So I tried to describe that.
Regards,
- Seung-Woo Kim
--
Seung-Woo Kim
Samsung Software R&D Center
--
next prev parent reply other threads:[~2014-03-06 2:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <187b01cf385bb9b4510$%debski@samsung.com>
2014-03-05 11:08 ` [PATCH] [media] s5-mfc: remove meaningless memory bank assignment Seung-Woo Kim
2014-03-05 11:42 ` Sachin Kamat
2014-03-06 2:13 ` Seung-Woo Kim [this message]
2014-03-06 3:28 ` Sachin Kamat
2014-03-06 4:35 ` Seung-Woo Kim
2014-03-06 4:55 ` [PATCH v3] [media] s5p-mfc: " Seung-Woo Kim
2014-03-06 4:59 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317D9B4.1080405@samsung.com \
--to=sw0312.kim@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox