[PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[Seung-Woo Kim]

There was assignment of memory bank with dma address converted
from physical address. But allocation has been changed with dma
function, so the assignment is not necessary.

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
change from v1
- fixes subject and adds proper description
---
 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
index 2475a3c..ee05f2d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
@@ -44,8 +44,6 @@ int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev)
 		return -ENOMEM;
 	}
 
-	dev->bank1 = dev->bank1;
-
 	if (HAS_PORTNUM(dev) && IS_TWOPORT(dev)) {
 		bank2_virt = dma_alloc_coherent(dev->mem_dev_r, 1 << MFC_BASE_ALIGN_ORDER,
 					&bank2_dma_addr, GFP_KERNEL);
-- 
1.7.4.1

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[Sachin Kamat]

On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
> There was assignment of memory bank with dma address converted
> from physical address. But allocation has been changed with dma
> function, so the assignment is not necessary.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> change from v1
> - fixes subject and adds proper description
> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
> index 2475a3c..ee05f2d 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
> @@ -44,8 +44,6 @@ int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev)
>                 return -ENOMEM;
>         }
>
> -       dev->bank1 = dev->bank1;

Are you sure this isn't some kind of typo? If not then your commit
description is too verbose
to actually say that the code is redundant and could be removed. The
code here is something like

 a = a;

which does not make sense nor add any value and hence redundant and
could be removed.

-- 
With warm regards,
Sachin

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[Seung-Woo Kim]

Hello Sachin,

On 2014년 03월 05일 20:42, Sachin Kamat wrote:
> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:

(...)

>> -       dev->bank1 = dev->bank1;
> 
> Are you sure this isn't some kind of typo? If not then your commit
> description is too verbose
> to actually say that the code is redundant and could be removed. The
> code here is something like
> 
>  a = a;
> 
> which does not make sense nor add any value and hence redundant and
> could be removed.

Right, this meaningless code can be simply removed as like the first
version. Anyway this redundant made from change of address type in
earlier patch. So I tried to describe that.

Regards,
- Seung-Woo Kim

-- 
Seung-Woo Kim
Samsung Software R&D Center
--

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[Sachin Kamat]

Hi Seung-Woo,

On 6 March 2014 07:43, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
> Hello Sachin,
>
> On 2014년 03월 05일 20:42, Sachin Kamat wrote:
>> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
>
> (...)
>
>>> -       dev->bank1 = dev->bank1;
>>
>> Are you sure this isn't some kind of typo? If not then your commit
>> description is too verbose
>> to actually say that the code is redundant and could be removed. The
>> code here is something like
>>
>>  a = a;
>>
>> which does not make sense nor add any value and hence redundant and
>> could be removed.
>
> Right, this meaningless code can be simply removed as like the first
> version. Anyway this redundant made from change of address type in
> earlier patch. So I tried to describe that.

What Kamil meant was that it is not a good practice to leave the
commit description
blank however trivial the patch might be. So a single line stating the
obvious should
be sufficient in this case.

-- 
With warm regards,
Sachin

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

[Seung-Woo Kim]

Hello Sachin,

On 2014년 03월 06일 12:28, Sachin Kamat wrote:
> Hi Seung-Woo,
> 
> On 6 March 2014 07:43, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
>> Hello Sachin,
>>
>> On 2014년 03월 05일 20:42, Sachin Kamat wrote:
>>> On 5 March 2014 16:38, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
>>
>> (...)
>>
>>>> -       dev->bank1 = dev->bank1;
>>>
>>> Are you sure this isn't some kind of typo? If not then your commit
>>> description is too verbose
>>> to actually say that the code is redundant and could be removed. The
>>> code here is something like
>>>
>>>  a = a;
>>>
>>> which does not make sense nor add any value and hence redundant and
>>> could be removed.
>>
>> Right, this meaningless code can be simply removed as like the first
>> version. Anyway this redundant made from change of address type in
>> earlier patch. So I tried to describe that.
> 
> What Kamil meant was that it is not a good practice to leave the
> commit description
> blank however trivial the patch might be. So a single line stating the
> obvious should
> be sufficient in this case.
> 

Ok, I will re-send with just simple statement.

Thanks,
- Seung-Woo Kim

-- 
Seung-Woo Kim
Samsung Software R&D Center
--

[PATCH v3] [media] s5p-mfc: remove meaningless memory bank assignment

[Seung-Woo Kim]

This patch removes meaningless assignment of memory bank to itself.

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
---
change from v2
- simplify description and change typo in subject
change from v1
- fixes subject and adds proper description
---
 drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
index 2475a3c..ee05f2d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
@@ -44,8 +44,6 @@ int s5p_mfc_alloc_firmware(struct s5p_mfc_dev *dev)
 		return -ENOMEM;
 	}
 
-	dev->bank1 = dev->bank1;
-
 	if (HAS_PORTNUM(dev) && IS_TWOPORT(dev)) {
 		bank2_virt = dma_alloc_coherent(dev->mem_dev_r, 1 << MFC_BASE_ALIGN_ORDER,
 					&bank2_dma_addr, GFP_KERNEL);
-- 
1.7.4.1

Re: [PATCH v3] [media] s5p-mfc: remove meaningless memory bank assignment

[Sachin Kamat]

Hi Seung-Woo,

On 6 March 2014 10:25, Seung-Woo Kim <sw0312.kim@samsung.com> wrote:
> This patch removes meaningless assignment of memory bank to itself.
>
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---

Thanks for re-doing this.

Acked-by: Sachin Kamat <sachin.kamat@linaro.org>

-- 
With warm regards,
Sachin