From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:26505 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbaCFEfq convert rfc822-to-8bit (ORCPT ); Wed, 5 Mar 2014 23:35:46 -0500 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1Z00H9WZFKO670@mailout1.samsung.com> for linux-media@vger.kernel.org; Thu, 06 Mar 2014 13:35:44 +0900 (KST) MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <5317FB2D.10303@samsung.com> Date: Thu, 06 Mar 2014 13:35:57 +0900 From: Seung-Woo Kim Reply-to: sw0312.kim@samsung.com To: Sachin Kamat Cc: linux-media , Kamil Debski , Mauro Carvalho Chehab , Marek Szyprowski , Seung-Woo Kim Subject: Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment References: <187b01cf385bb9b4510$%debski@samsung.com> <1394017710-671-1-git-send-email-sw0312.kim@samsung.com> <5317D9B4.1080405@samsung.com> In-reply-to: Sender: linux-media-owner@vger.kernel.org List-ID: Hello Sachin, On 2014년 03월 06일 12:28, Sachin Kamat wrote: > Hi Seung-Woo, > > On 6 March 2014 07:43, Seung-Woo Kim wrote: >> Hello Sachin, >> >> On 2014년 03월 05일 20:42, Sachin Kamat wrote: >>> On 5 March 2014 16:38, Seung-Woo Kim wrote: >> >> (...) >> >>>> - dev->bank1 = dev->bank1; >>> >>> Are you sure this isn't some kind of typo? If not then your commit >>> description is too verbose >>> to actually say that the code is redundant and could be removed. The >>> code here is something like >>> >>> a = a; >>> >>> which does not make sense nor add any value and hence redundant and >>> could be removed. >> >> Right, this meaningless code can be simply removed as like the first >> version. Anyway this redundant made from change of address type in >> earlier patch. So I tried to describe that. > > What Kamil meant was that it is not a good practice to leave the > commit description > blank however trivial the patch might be. So a single line stating the > obvious should > be sufficient in this case. > Ok, I will re-send with just simple statement. Thanks, - Seung-Woo Kim -- Seung-Woo Kim Samsung Software R&D Center --