From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:59761 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753730AbaCJP3O (ORCPT ); Mon, 10 Mar 2014 11:29:14 -0400 Message-ID: <531DDA48.9000702@iki.fi> Date: Mon, 10 Mar 2014 17:29:12 +0200 From: Antti Palosaari MIME-Version: 1.0 To: Hans Verkuil , Linux Media Mailing List Subject: Re: [PATCH] rtl2832u_sdr: fixing v4l2-compliance issues References: <5317B182.8050200@xs4all.nl> In-Reply-To: <5317B182.8050200@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Moikka Hans! On 06.03.2014 01:21, Hans Verkuil wrote: > Antti, > > Attached is a patch that fixed all but one v4l2-compliance error: > > fail: v4l2-test-controls.cpp(295): returned control value out of range > fail: v4l2-test-controls.cpp(357): invalid control 00a2090c > test VIDIOC_G/S_CTRL: FAIL > fail: v4l2-test-controls.cpp(465): returned control value out of range > fail: v4l2-test-controls.cpp(573): invalid control 00a2090c > test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL > > That's the BANDWIDTH control and it returned value 3200000 when the minimum was 6000000. > I couldn't trace where that came from in the limited time I spent on it, I expect you > can find it much quicker. That is because I added native V4L2_CID_RF_TUNER_BANDWIDTH support only for E4000 tuner driver. The others, FC0012, FC0013 and R820T are set via DVB API by rtl2832_sdr driver, which is quite hackish solution. Devices having E4000 works correctly. Dunno if it wise to hack rtl2832_sdr and clamp values to valid per tuner or leave it as it is. Adding V4L2_CID_RF_TUNER_BANDWIDTH to those 3 tuner drivers is also quite trivial... regards Antti -- http://palosaari.fi/