From: Hans Verkuil <hverkuil@xs4all.nl>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: hdegoede@redhat.com
Subject: libv4lconvert: remove broken ALTERNATE handling
Date: Fri, 14 Mar 2014 13:39:00 +0100 [thread overview]
Message-ID: <5322F864.6050507@xs4all.nl> (raw)
The V4L2 specification used to say that if field == V4L2_FIELD_ALTERNATE, the
height would have to be divided by two. This is incorrect, the height is that of
a single field. This has been corrected in the spec, now this code in libv4lconvert
needs to be removed as well.
Tested with both bttv and saa7146, the only two drivers supporting FIELD_ALTERNATE
today.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
lib/libv4lconvert/libv4lconvert.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/lib/libv4lconvert/libv4lconvert.c b/lib/libv4lconvert/libv4lconvert.c
index e2afc27..df06b75 100644
--- a/lib/libv4lconvert/libv4lconvert.c
+++ b/lib/libv4lconvert/libv4lconvert.c
@@ -1328,13 +1328,6 @@ int v4lconvert_convert(struct v4lconvert_data *data,
return to_copy;
}
- /* When field is V4L2_FIELD_ALTERNATE, each buffer only contains half the
- lines */
- if (my_src_fmt.fmt.pix.field == V4L2_FIELD_ALTERNATE) {
- my_src_fmt.fmt.pix.height /= 2;
- my_dest_fmt.fmt.pix.height /= 2;
- }
-
/* sanity check, is the dest buffer large enough? */
switch (my_dest_fmt.fmt.pix.pixelformat) {
case V4L2_PIX_FMT_RGB24:
--
1.9.0
next reply other threads:[~2014-03-14 12:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 12:39 Hans Verkuil [this message]
2014-03-14 18:53 ` libv4lconvert: remove broken ALTERNATE handling Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5322F864.6050507@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox