From: Shuah Khan <shuah.kh@samsung.com>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>, m.chehab@samsung.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
shuahkhan@gmail.com
Subject: Re: [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len()
Date: Sat, 22 Mar 2014 16:03:27 -0600 [thread overview]
Message-ID: <532E08AF.5030008@samsung.com> (raw)
In-Reply-To: <532DCB06.9040601@googlemail.com>
On 03/22/2014 11:40 AM, Frank Schäfer wrote:
>
> I'm more concerned about the fact that readers of the code could think
> that this is a write with a variable length, while the length is
> actually always the same.
Fair enough.
>
> em28xx_reg_len() is a somewhat dirty hack for vidioc_[g,s]_register
> debugging ioctls only.
I didn't realize that. In that case, it doesn't make sense to propagate
the change to non-debug code. This patch can be dropped. I thought
em28xx_reg_len() is good example of finding register length for these
registers.
> Btw, what happens when you try to compile the code with this patch
> applied and CONFIG_VIDEO_ADV_DEBUG disabled ? ;-)
CONFIG_VIDEO_ADV_DEBUG is disabled in my config.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
prev parent reply other threads:[~2014-03-22 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 21:04 [PATCH] media: em28xx-video - change em28xx_scaler_set() to use em28xx_reg_len() Shuah Khan
2014-03-22 12:32 ` Frank Schäfer
2014-03-22 15:22 ` Shuah Khan
2014-03-22 17:40 ` Frank Schäfer
2014-03-22 22:03 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532E08AF.5030008@samsung.com \
--to=shuah.kh@samsung.com \
--cc=fschaefer.oss@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox