* [PATCH] adv7611: Set HPD GPIO direction to output
@ 2014-03-26 2:28 Laurent Pinchart
2014-03-26 9:52 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-03-26 2:28 UTC (permalink / raw)
To: linux-media; +Cc: Hans Verkuil, Lars-Peter Clausen
The HPD GPIO is used as an output but its direction is never set. Fix
it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/adv7604.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This patch applies on top of the ADV7611 support series queued for v3.16.
diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
index 51f14ab..b38ebb9 100644
--- a/drivers/media/i2c/adv7604.c
+++ b/drivers/media/i2c/adv7604.c
@@ -2845,7 +2845,7 @@ static int adv7604_probe(struct i2c_client *client,
if (IS_ERR(state->hpd_gpio[i]))
continue;
- gpiod_set_value_cansleep(state->hpd_gpio[i], 0);
+ gpiod_direction_output(state->hpd_gpio[i], 0);
v4l_info(client, "Handling HPD %u GPIO\n", i);
}
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] adv7611: Set HPD GPIO direction to output
2014-03-26 2:28 [PATCH] adv7611: Set HPD GPIO direction to output Laurent Pinchart
@ 2014-03-26 9:52 ` Hans Verkuil
2014-03-26 10:03 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Hans Verkuil @ 2014-03-26 9:52 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, Hans Verkuil, Lars-Peter Clausen
Hi Laurent,
Stupid question perhaps, but why is gpiod_set_value_cansleep() removed?
Does setting the output direction force the value to 0 as well?
Regards,
Hans
On 03/26/14 03:28, Laurent Pinchart wrote:
> The HPD GPIO is used as an output but its direction is never set. Fix
> it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/adv7604.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch applies on top of the ADV7611 support series queued for v3.16.
>
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 51f14ab..b38ebb9 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -2845,7 +2845,7 @@ static int adv7604_probe(struct i2c_client *client,
> if (IS_ERR(state->hpd_gpio[i]))
> continue;
>
> - gpiod_set_value_cansleep(state->hpd_gpio[i], 0);
> + gpiod_direction_output(state->hpd_gpio[i], 0);
>
> v4l_info(client, "Handling HPD %u GPIO\n", i);
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] adv7611: Set HPD GPIO direction to output
2014-03-26 9:52 ` Hans Verkuil
@ 2014-03-26 10:03 ` Laurent Pinchart
2014-03-26 10:01 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2014-03-26 10:03 UTC (permalink / raw)
To: Hans Verkuil; +Cc: linux-media, Hans Verkuil, Lars-Peter Clausen
Hi Hans,
On Wednesday 26 March 2014 10:52:30 Hans Verkuil wrote:
> Hi Laurent,
>
> Stupid question perhaps, but why is gpiod_set_value_cansleep() removed?
> Does setting the output direction force the value to 0 as well?
The last argument to gpiod_direction_output() sets the initial output level,
yes.
> On 03/26/14 03:28, Laurent Pinchart wrote:
> > The HPD GPIO is used as an output but its direction is never set. Fix
> > it.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >
> > drivers/media/i2c/adv7604.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > This patch applies on top of the ADV7611 support series queued for v3.16.
> >
> > diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> > index 51f14ab..b38ebb9 100644
> > --- a/drivers/media/i2c/adv7604.c
> > +++ b/drivers/media/i2c/adv7604.c
> > @@ -2845,7 +2845,7 @@ static int adv7604_probe(struct i2c_client *client,
> > if (IS_ERR(state->hpd_gpio[i]))
> > continue;
> >
> > - gpiod_set_value_cansleep(state->hpd_gpio[i], 0);
> > + gpiod_direction_output(state->hpd_gpio[i], 0);
> >
> > v4l_info(client, "Handling HPD %u GPIO\n", i);
> > }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] adv7611: Set HPD GPIO direction to output
2014-03-26 10:03 ` Laurent Pinchart
@ 2014-03-26 10:01 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2014-03-26 10:01 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, Hans Verkuil, Lars-Peter Clausen
In that case:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
On 03/26/14 11:03, Laurent Pinchart wrote:
> Hi Hans,
>
> On Wednesday 26 March 2014 10:52:30 Hans Verkuil wrote:
>> Hi Laurent,
>>
>> Stupid question perhaps, but why is gpiod_set_value_cansleep() removed?
>> Does setting the output direction force the value to 0 as well?
>
> The last argument to gpiod_direction_output() sets the initial output level,
> yes.
>
>> On 03/26/14 03:28, Laurent Pinchart wrote:
>>> The HPD GPIO is used as an output but its direction is never set. Fix
>>> it.
>>>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> ---
>>>
>>> drivers/media/i2c/adv7604.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> This patch applies on top of the ADV7611 support series queued for v3.16.
>>>
>>> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
>>> index 51f14ab..b38ebb9 100644
>>> --- a/drivers/media/i2c/adv7604.c
>>> +++ b/drivers/media/i2c/adv7604.c
>>> @@ -2845,7 +2845,7 @@ static int adv7604_probe(struct i2c_client *client,
>>> if (IS_ERR(state->hpd_gpio[i]))
>>> continue;
>>>
>>> - gpiod_set_value_cansleep(state->hpd_gpio[i], 0);
>>> + gpiod_direction_output(state->hpd_gpio[i], 0);
>>>
>>> v4l_info(client, "Handling HPD %u GPIO\n", i);
>>> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-26 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-26 2:28 [PATCH] adv7611: Set HPD GPIO direction to output Laurent Pinchart
2014-03-26 9:52 ` Hans Verkuil
2014-03-26 10:03 ` Laurent Pinchart
2014-03-26 10:01 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).