From: Hans Verkuil <hverkuil@xs4all.nl>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: LMML <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
LDOC <linux-doc@vger.kernel.org>, Rob Landley <rob@landley.net>
Subject: Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
Date: Wed, 02 Apr 2014 11:38:47 +0200 [thread overview]
Message-ID: <533BDAA7.5070704@xs4all.nl> (raw)
In-Reply-To: <1395683489-25986-1-git-send-email-prabhakar.csengg@gmail.com>
On 03/24/14 18:51, Lad, Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> Documentation/video4linux/v4l2-pci-skeleton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
> index 3a1c0d2..61a56f4 100644
> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
> @@ -87,7 +87,7 @@ struct skel_buffer {
>
> static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
> {
> - return container_of(vb2, struct skel_buffer, vb);
> + return container_of(vb2, struct skel_buffer, vb2);
Why is this a type? The vb2_buffer member in struct skel_buffer is called
'vb', so this should be correct.
Regards,
Hans
> }
>
> static const struct pci_device_id skeleton_pci_tbl[] = {
>
next prev parent reply other threads:[~2014-04-02 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 17:51 [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer Lad, Prabhakar
2014-04-02 9:38 ` Hans Verkuil [this message]
2014-04-02 10:22 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533BDAA7.5070704@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox