From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Mauro Carvalho Chehab <m.chehab@samsung.com>
Subject: Re: [PATCH v2 4/6] v4l: vsp1: Add DT support
Date: Thu, 03 Apr 2014 12:17:18 +0200 [thread overview]
Message-ID: <533D352E.7050302@samsung.com> (raw)
In-Reply-To: <1484365.AL7arRdPNh@avalon>
Hi Laurent,
On 03/04/14 01:16, Laurent Pinchart wrote:
>>> @@ -534,6 +569,7 @@ static struct platform_driver vsp1_platform_driver = {
>>> > > .owner = THIS_MODULE,
>>> > > .name = "vsp1",
>>> > > .pm = &vsp1_pm_ops,
>>> > > + .of_match_table = of_match_ptr(vsp1_of_match),
>> >
>> > Is of_match_ptr() really useful here, when vsp1_of_match[] array is always
>> > compiled in ?
>
> Would it be better to compile the vsp1_of_match[] array conditionally ? On the
> other hand the driver is only useful (at least at the moment) on ARM Renesas
> SoCs, which are transitioning to DT anyway.
Given that #ifdefs could be soon removed anyway (when the platform becomes
dt-only) I guess it's better not to introduce it now.
--
Regards,
Sylwester
prev parent reply other threads:[~2014-04-03 10:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 18:01 [PATCH v2 4/6] v4l: vsp1: Add DT support Laurent Pinchart
2014-04-02 21:37 ` Sylwester Nawrocki
2014-04-02 23:16 ` Laurent Pinchart
2014-04-03 10:17 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533D352E.7050302@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).