From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media <linux-media@vger.kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 7/8] [media] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression
Date: Wed, 09 Apr 2014 10:28:38 +0200 [thread overview]
Message-ID: <534504B6.2020202@samsung.com> (raw)
In-Reply-To: <CAK9yfHz+F=pfNN7nQn-HE5L=uux+cVhBRoHa4wMjRT1VZTRTyw@mail.gmail.com>
On 04/09/2014 09:56 AM, Sachin Kamat wrote:
> Hi Jacek,
>
> On 9 April 2014 13:01, Jacek Anaszewski <j.anaszewski@samsung.com> wrote:
>> On 04/08/2014 09:49 AM, Sachin Kamat wrote:
>>>
>
>> Hello Sachin,
>>
>> Thanks for the review. I put it into info message because this is
>> rather hard for the user to figure out why the adjustment occurred,
>> bearing in mind that JPEG with the same subsampling and even width
>> is decompressed properly. This is not a common adjustment like
>> alignment, and thus in my opinion it requires displaying the
>> information. Are there some rules that say what cases are relevant
>> for using the v4l2_info macro?
>
> Not really, but generally info messages are concise and detailed explanations
> provided as part of comments.
>
Thanks for the explanation, I will stick to it.
Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2014-04-09 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 13:16 [PATCH 1/8] [media] s5p-jpeg: Add fmt_ver_flag field to the s5p_jpeg_variant structure Jacek Anaszewski
2014-04-07 13:16 ` [PATCH 2/8] [media] s5p-jpeg: Perform fourcc downgrade only for Exynos4x12 SoCs Jacek Anaszewski
2014-04-07 13:16 ` [PATCH 3/8] [media] s5p-jpeg: Add m2m_ops field to the s5p_jpeg_variant structure Jacek Anaszewski
2014-04-07 13:16 ` [PATCH 4/8] [media] s5p-jpeg: Fix build break when CONFIG_OF is undefined Jacek Anaszewski
2014-04-08 7:43 ` Sachin Kamat
2014-04-07 13:16 ` [PATCH 5/8] [media] s5p-jpeg: g_selection callback should always succeed Jacek Anaszewski
2014-04-07 13:16 ` [PATCH 6/8] [media] s5p-jpeg: Fix sysmmu page fault Jacek Anaszewski
2014-04-07 13:16 ` [PATCH 7/8] [media] s5p_jpeg: Prevent JPEG 4:2:0 > YUV 4:2:0 decompression Jacek Anaszewski
2014-04-08 7:49 ` Sachin Kamat
2014-04-09 7:31 ` Jacek Anaszewski
2014-04-09 7:56 ` Sachin Kamat
2014-04-09 8:28 ` Jacek Anaszewski [this message]
2014-04-07 13:16 ` [PATCH 8/8] [media] s5p_jpeg: Fix NV12 format entry related to S5C2120 SoC Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534504B6.2020202@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox