From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:27418 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755021AbaDNPuB (ORCPT ); Mon, 14 Apr 2014 11:50:01 -0400 Message-id: <534C03A1.6040005@samsung.com> Date: Mon, 14 Apr 2014 17:49:53 +0200 From: Tomasz Stanislawski MIME-version: 1.0 To: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Cc: pawel.moll@arm.com, b.zolnierkie@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, rahul.sharma@samsung.com, m.chehab@samsung.com Subject: Re: [PATCH 1/4] drm: exynos: hdmi: simplify extracting hpd-gpio from DT References: <1397487622-3577-1-git-send-email-t.stanislaws@samsung.com> <1397487622-3577-2-git-send-email-t.stanislaws@samsung.com> In-reply-to: <1397487622-3577-2-git-send-email-t.stanislaws@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 04/14/2014 05:00 PM, Tomasz Stanislawski wrote: > This patch eliminates redundant checks while retrieving HPD gpio from DT during > HDMI's probe(). > > Signed-off-by: Tomasz Stanislawski > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c > index 9a6d652..d2d6e2e 100644 > --- a/drivers/gpu/drm/exynos/exynos_hdmi.c > +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c > @@ -2016,23 +2016,18 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata > { > struct device_node *np = dev->of_node; > struct s5p_hdmi_platform_data *pd; > - u32 value; > > pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > if (!pd) > - goto err_data; > + return NULL; > > - if (!of_find_property(np, "hpd-gpio", &value)) { > + pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); > + if (gpio_is_valid(pd->hpd_gpio)) { Sorry. Should be !gpio_is_valid(). > DRM_ERROR("no hpd gpio property found\n"); > - goto err_data; > + return NULL; > } > > - pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); > - > return pd; > - > -err_data: > - return NULL; > } > > static struct of_device_id hdmi_match_types[] = { >