From: Hans Verkuil <hverkuil@xs4all.nl>
To: it-support <it@sca-uk.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: stoth@kernellabs.com
Subject: Re: [PATCH] cx23885: add support for Hauppauge ImpactVCB-e
Date: Tue, 15 Apr 2014 12:43:28 +0200 [thread overview]
Message-ID: <534D0D50.6020600@xs4all.nl> (raw)
In-Reply-To: <534D0CD5.3090906@sca-uk.com>
On 04/15/2014 12:41 PM, it-support wrote:
> Hi Guys,
>
> This is a very noobie question, but my 'patch' command does not return
> to the command prompt.
>
> I assume that my problem is one (or all four) of:
>
> 1) the patch doesn't start or end where I think it does (I assume the
> first line is
>
> diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c
>
> and the last line is:
>
> #define GPIO_1 0x00000002
>
> 2) I have put it in the wrong directory (I tried:
>
> ~/linuxtv/media_build/linux/drivers/media/pci/cx23885/
>
> and
>
> ~/linuxtv/media_build
>
> 3) My patch syntax is wrong. I run it in the same directory as the file
> like this: patch -b cx23885.diff
It's: patch -b <cx23885.diff
I still make this mistake and I've been doing this for many, many years :-)
Regards,
Hans
next prev parent reply other threads:[~2014-04-15 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 13:57 [PATCH] cx23885: add support for Hauppauge ImpactVCB-e Hans Verkuil
2014-04-14 14:22 ` Steven Toth
2014-04-15 10:41 ` it-support
2014-04-15 10:43 ` Hans Verkuil [this message]
2014-04-17 21:07 ` Steve Cookson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534D0D50.6020600@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=it@sca-uk.com \
--cc=linux-media@vger.kernel.org \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox