From: Shuah Khan <shuah.kh@samsung.com>
To: Tejun Heo <tj@kernel.org>
Cc: gregkh@linuxfoundation.org, m.chehab@samsung.com,
rafael.j.wysocki@intel.com, linux@roeck-us.net,
toshi.kani@hp.com, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, shuahkhan@gmail.com,
Shuah Khan <shuah.kh@samsung.com>
Subject: Re: [RFC PATCH 2/2] drivers/base: add managed token devres interfaces
Date: Thu, 17 Apr 2014 17:27:06 -0600 [thread overview]
Message-ID: <5350634A.2030608@samsung.com> (raw)
In-Reply-To: <20140417202221.GU15326@htj.dyndns.org>
On 04/17/2014 02:22 PM, Tejun Heo wrote:
> On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
Please do not implement locking
> primitive directly if at all avoidable. Why can't it use a mutex
> embedded in the data area of a devres entry? And if you for some
> reason have to implement it directly, at least add lockdep
> annotations.
>
Thanks. This is helpful. Yes it does simplify the code with mutex
embedded in the devres data area. I am working on a v2 patch with
that change.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
next prev parent reply other threads:[~2014-04-17 23:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:21 [RFC PATCH 0/2] managed token devres interfaces Shuah Khan
2014-04-09 15:21 ` [RFC PATCH 1/2] drivers/base: add new devres_update() interface to devres_* Shuah Khan
2014-04-09 15:21 ` [RFC PATCH 2/2] drivers/base: add managed token devres interfaces Shuah Khan
2014-04-16 21:58 ` Tejun Heo
2014-04-17 20:01 ` Shuah Khan
2014-04-17 20:10 ` Tejun Heo
2014-04-17 20:22 ` Tejun Heo
2014-04-17 23:27 ` Shuah Khan [this message]
2014-04-17 20:50 ` Shuah Khan
2014-04-09 19:17 ` [RFC PATCH 0/2] " Greg KH
2014-04-09 22:44 ` Shuah Khan
2014-04-10 11:04 ` One Thousand Gnomes
2014-04-10 11:38 ` Mauro Carvalho Chehab
2014-04-10 11:46 ` One Thousand Gnomes
2014-04-10 14:39 ` Mauro Carvalho Chehab
2014-04-11 20:28 ` Shuah Khan
2014-04-14 22:48 ` Shuah Khan
2014-04-10 14:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5350634A.2030608@samsung.com \
--to=shuah.kh@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m.chehab@samsung.com \
--cc=rafael.j.wysocki@intel.com \
--cc=shuahkhan@gmail.com \
--cc=tj@kernel.org \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox