From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:40526 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbaEGNg6 (ORCPT ); Wed, 7 May 2014 09:36:58 -0400 Message-id: <536A36F5.5080303@samsung.com> Date: Wed, 07 May 2014 15:36:53 +0200 From: Tomasz Stanislawski MIME-version: 1.0 To: Rahul Sharma , Kishon Vijay Abraham I Cc: Sylwester Nawrocki , Andrzej Hajda , "linux-kernel@vger.kernel.org" , linux-samsung-soc , "devicetree@vger.kernel.org" , "linux-media@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Kukjin Kim , Kyungmin Park , Rob Herring , Grant Likely , sunil joshi Subject: Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver References: <1396967856-27470-1-git-send-email-t.stanislaws@samsung.com> <1396967856-27470-2-git-send-email-t.stanislaws@samsung.com> <534506B1.4040908@samsung.com> <53451A60.4050803@samsung.com> <53675D72.70103@ti.com> In-reply-to: Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 05/07/2014 12:38 PM, Rahul Sharma wrote: > On 5 May 2014 15:14, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Wednesday 09 April 2014 03:31 PM, Sylwester Nawrocki wrote: >>> Hi, >>> >>> On 09/04/14 11:12, Rahul Sharma wrote: >>>> Idea looks good. How about keeping compatible which is independent >>>> of SoC, something like "samsung,exynos-simple-phy" and provide Reg >>>> and Bit through phy provider node. This way we can avoid SoC specific >>>> hardcoding in phy driver and don't need to look into dt bindings for >>>> each new SoC. >>> >>> I believe it is a not recommended approach. >> >> Why not? We should try to avoid hard coding in the driver code. Moreover by >> avoiding hardcoding we can make it a generic driver for single bit PHYs. >> > > +1. > > @Tomasz, any plans to consider this approach for simple phy driver? > > Regards, > Rahul Sharma. > Hi Rahul, Initially, I wanted to make a very generic driver and to add bit and register (or its offset) attribute to the PHY node. However, there was a very strong opposition from DT maintainers to adding any bit related configuration to DT. The current solution was designed to be a trade-off between being generic and being accepted :). Regards, Tomasz Stanislawski >> Cheers >> Kishon >