From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@iki.fi>, Antti Palosaari <crope@iki.fi>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
LMML <linux-media@vger.kernel.org>
Subject: Re: V4L control units
Date: Fri, 09 May 2014 14:57:13 +0200 [thread overview]
Message-ID: <536CD0A9.4020904@xs4all.nl> (raw)
In-Reply-To: <20140508090446.GG8753@valkosipuli.retiisi.org.uk>
On 05/08/2014 11:04 AM, Sakari Ailus wrote:
> Heippa!
>
> On Wed, May 07, 2014 at 03:57:11PM +0300, Antti Palosaari wrote:
>> What is preferred way implement controls that could have some known
>> unit or unknown unit? For example for gain controls, I would like to
>> offer gain in unit of dB (decibel) and also some unknown driver
>> specific unit. Should I two controls, one for each unit?
>>
>> Like that
>>
>> V4L2_CID_RF_TUNER_LNA_GAIN_AUTO
>> V4L2_CID_RF_TUNER_LNA_GAIN
>> V4L2_CID_RF_TUNER_LNA_GAIN_dB
>
> I suppose that on any single device there would be a single unit to control
> a given... control. Some existing controls do document the unit as well but
> I don't think that's scalable nor preferrable. This way we'd have many
> different controls to control the same thing but just using a different
> unit. The auto control is naturally different. Hans did have a patch to add
> the unit to queryctrl (in the form of QUERY_EXT_CTRL).
Well, that's going to be dropped again. There were too many comments about
that during the mini-summit and it was not critical for me.
>
> <URL:http://www.spinics.net/lists/linux-media/msg73136.html>
>
> I wish we can get these in relatively soon.
Sakari, I think you will have to push this if you want this done.
One interesting thing to look at: the AVB IEEE 1722.1 standard has extensive
support for all sorts of units. I don't know if you have access to the standard
document, but it might be interesting to look at what they do there.
Regards,
Hans
next prev parent reply other threads:[~2014-05-09 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 12:57 V4L control units Antti Palosaari
2014-05-08 9:04 ` Sakari Ailus
2014-05-09 12:57 ` Hans Verkuil [this message]
2014-05-09 13:46 ` Sakari Ailus
2014-05-09 13:56 ` Hans Verkuil
-- strict thread matches above, loose matches on Subject: below --
2014-05-07 12:55 Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536CD0A9.4020904@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox