From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:22737 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932720AbaE2OzW (ORCPT ); Thu, 29 May 2014 10:55:22 -0400 Message-ID: <53874B33.5050109@linux.intel.com> Date: Thu, 29 May 2014 17:58:59 +0300 From: Sakari Ailus MIME-Version: 1.0 To: Laurent Pinchart CC: linux-media@vger.kernel.org, hverkuil@xs4all.nl Subject: Re: [PATCH v3 1/3] v4l: Add test pattern colour component controls References: <1401374448-30411-1-git-send-email-sakari.ailus@linux.intel.com> <1401374448-30411-2-git-send-email-sakari.ailus@linux.intel.com> <48325310.Ydj7bxFi9C@avalon> In-Reply-To: <48325310.Ydj7bxFi9C@avalon> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Laurent, Thanks for your comments. Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thursday 29 May 2014 17:40:46 Sakari Ailus wrote: >> In many cases the test pattern has selectable values for each colour >> component. Implement controls for raw bayer components. Additional controls >> should be defined for colour components that are not covered by these >> controls. >> >> Signed-off-by: Sakari Ailus >> --- >> Documentation/DocBook/media/v4l/controls.xml | 34 +++++++++++++++++++++++++ >> drivers/media/v4l2-core/v4l2-ctrls.c | 4 ++++ >> include/uapi/linux/v4l2-controls.h | 4 ++++ >> 3 files changed, 42 insertions(+) >> >> diff --git a/Documentation/DocBook/media/v4l/controls.xml >> b/Documentation/DocBook/media/v4l/controls.xml index 47198ee..bf23994 >> 100644 >> --- a/Documentation/DocBook/media/v4l/controls.xml >> +++ b/Documentation/DocBook/media/v4l/controls.xml >> @@ -4677,6 +4677,40 @@ interface and may change in the future. >> conversion. >> >> >> + >> + > spanname="id">V4L2_CID_TEST_PATTERN_RED + >> integer >> + >> + >> + Test pattern red colour component. >> + >> + >> + >> + > spanname="id">V4L2_CID_TEST_PATTERN_GREENR >> + integer >> + >> + >> + Test pattern green (next to red) >> + colour component. > > What about non-Bayer RGB sensors ? Should they use the GREENR or the GREENB > control for the green component ? Or a different control ? A different one. It should be simply green. I could add it to the same patch if you wish. > I'm wondering whether we shouldn't have a single test pattern color control > and create a color type using Hans' complex controls API. A raw bayer four-pixel value, you mean? -- Regards, Sakari Ailus sakari.ailus@linux.intel.com