From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Pawel Osciak <pawel@osciak.com>,
LMML <linux-media@vger.kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag
Date: Fri, 06 Jun 2014 11:55:49 +0200 [thread overview]
Message-ID: <53919025.1060407@xs4all.nl> (raw)
In-Reply-To: <1435470.qABIAKhMXR@avalon>
On 06/06/2014 11:46 AM, Laurent Pinchart wrote:
> Hi Hans,
>
> On Friday 06 June 2014 11:31:55 Hans Verkuil wrote:
>> On 06/06/2014 11:19 AM, Laurent Pinchart wrote:
>>> Hi Pawel,
>>>
>>> On Friday 06 June 2014 14:31:15 Pawel Osciak wrote:
>>>> Hi Laurent,
>>>> Thanks for the patch. Did you test this to work in fileio mode? Looks
>>>> like it should, but would like to make sure.
>>>
>>> No, I haven't tested it. The OMAP4 ISS driver, which is my test target for
>>> this patch, doesn't support fileio mode. Adding VB2_READ would be easy,
>>> but the driver requires configuring the format on the file handle used for
>>> streaming, so I can't just run cat /dev/video*.
>>
>> Just test with vivi.
>
> But vivi doesn't call the new vb2_queue_error() function. I understand that
> your vivi rework would make that easier as you now have an error control.
> Should I hack something similar in the existing vivi driver ? Any pointer ?
>
Just hack it in for testing. E.g. call it when the button control is pressed
(see vivi_s_ctrl).
Regards,
Hans
next prev parent reply other threads:[~2014-06-06 9:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 12:23 [PATCH/RFC v2 0/2] vb2: Report POLLERR for fatal errors only Laurent Pinchart
2014-06-05 12:23 ` [PATCH/RFC v2 1/2] v4l: vb2: Don't return POLLERR during transient buffer underruns Laurent Pinchart
2014-06-06 5:15 ` Pawel Osciak
2014-06-06 9:50 ` Hans de Goede
2014-06-06 9:58 ` Hans Verkuil
2014-06-06 13:42 ` Laurent Pinchart
2014-09-15 11:14 ` Hans Verkuil
2014-09-15 12:02 ` Mauro Carvalho Chehab
2014-09-15 12:49 ` Laurent Pinchart
2014-09-15 12:56 ` Nicolas Dufresne
2014-09-15 13:55 ` Mauro Carvalho Chehab
2014-09-15 14:33 ` Nicolas Dufresne
2014-09-15 15:51 ` Mauro Carvalho Chehab
2014-09-16 10:29 ` Laurent Pinchart
2014-09-16 11:18 ` Hans Verkuil
2014-09-16 12:19 ` Laurent Pinchart
2014-06-05 12:23 ` [PATCH/RFC v2 2/2] v4l: vb2: Add fatal error condition flag Laurent Pinchart
2014-06-06 5:31 ` Pawel Osciak
2014-06-06 9:19 ` Laurent Pinchart
2014-06-06 9:31 ` Hans Verkuil
2014-06-06 9:46 ` Laurent Pinchart
2014-06-06 9:55 ` Hans Verkuil [this message]
2014-06-06 13:42 ` Laurent Pinchart
2014-06-06 13:45 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53919025.1060407@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nicolas.dufresne@collabora.com \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).