From: Antti Palosaari <crope@iki.fi>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [media] dvb_usb_v2: use dev_* logging macros
Date: Thu, 12 Jun 2014 17:38:24 +0300 [thread overview]
Message-ID: <5399BB60.4000308@iki.fi> (raw)
In-Reply-To: <20140612143002.GC13103@mwanda>
Moikka Dan,
Thank for the report. I will check that later... I am now back from
traveling and there is a lot of stuff on my queue waiting for action.
regards
Antti
On 06/12/2014 05:30 PM, Dan Carpenter wrote:
> Hello Antti Palosaari,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch d10d1b9ac97b: "[media] dvb_usb_v2: use dev_* logging
> macros" from Jun 26, 2012, leads to the following Smatch complaint:
>
> drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c:31 dvb_usb_v2_generic_io()
> error: we previously assumed 'd' could be null (see line 29)
>
> drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c
> 28
> 29 if (!d || !wbuf || !wlen || !d->props->generic_bulk_ctrl_endpoint ||
> ^^
> Old check.
>
> 30 !d->props->generic_bulk_ctrl_endpoint_response) {
> 31 dev_dbg(&d->udev->dev, "%s: failed=%d\n", __func__, -EINVAL);
> ^^^^^^^^^^^^^
> New dereference.
>
> 32 return -EINVAL;
> 33 }
>
> regards,
> dan carpenter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
http://palosaari.fi/
prev parent reply other threads:[~2014-06-12 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 14:30 [media] dvb_usb_v2: use dev_* logging macros Dan Carpenter
2014-06-12 14:38 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5399BB60.4000308@iki.fi \
--to=crope@iki.fi \
--cc=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).