WG: Patch pctv452e.c: Suppress annoying dmesg-SPAM

WG: Patch pctv452e.c: Suppress annoying dmesg-SPAM

[Daniel Mayer]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

Hi,
attached micro-patch removes the text output of an error-message of the
PCTV452e-driver. The error messages "I2C error: [.]" do not help any user of
the kernel, so whatever causes the error, it does not hamper the function of
my TT-3600 USB receiver.
So: Just remove the entries in the dmesg, for it is quite spam-like. 
Perhaps someone with deeper knowledge could have a look up the background of
this message and fix it?
Thanks,
Daniel

(resent as plain-text; sorry)

[-- Attachment #2: pctv452e.patch --]
[-- Type: application/octet-stream, Size: 491 bytes --]

--- pctv452e.c.orig	2014-05-30 22:16:28.638949289 +0200
+++ pctv452e.c	2014-05-30 22:16:43.165359598 +0200
@@ -446,11 +446,11 @@ static int pctv452e_i2c_msg(struct dvb_u
 	return rcv_len;
 
 failed:
-	err("I2C error %d; %02X %02X  %02X %02X %02X -> "
+/*	err("I2C error %d; %02X %02X  %02X %02X %02X -> "
 	     "%02X %02X  %02X %02X %02X.",
 	     ret, SYNC_BYTE_OUT, id, addr << 1, snd_len, rcv_len,
 	     buf[0], buf[1], buf[4], buf[5], buf[6]);
-
+*/
 	return ret;
 }
 

Re: WG: Patch pctv452e.c: Suppress annoying dmesg-SPAM

[Antti Palosaari]

Moikka Daniel,

On 05/31/2014 12:16 AM, Daniel Mayer wrote:
> Hi,
> attached micro-patch removes the text output of an error-message of the
> PCTV452e-driver. The error messages "I2C error: [.]" do not help any user of
> the kernel, so whatever causes the error, it does not hamper the function of
> my TT-3600 USB receiver.
> So: Just remove the entries in the dmesg, for it is quite spam-like.
> Perhaps someone with deeper knowledge could have a look up the background of
> this message and fix it?
> Thanks,
> Daniel
>
> (resent as plain-text; sorry)
>

That is not proper fix, it just hides it by removing proper error logging.

I debugged real reason earlier:
http://permalink.gmane.org/gmane.linux.drivers.video-input-infrastructure/50491


I have got even hardware, but I am totally overloaded so I have to 
prioritize things. I am happy to see if someone fixes it properly.

regards
Antti

-- 
http://palosaari.fi/