From: Hans Verkuil <hverkuil@xs4all.nl>
To: Divneil Wadhawan <divneil@outlook.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: vb2_reqbufs() is not allowing more than VIDEO_MAX_FRAME
Date: Fri, 04 Jul 2014 09:47:58 +0200 [thread overview]
Message-ID: <53B65C2E.9040503@xs4all.nl> (raw)
In-Reply-To: <BAY176-W960662BE81D5920B94F97A9350@phx.gbl>
On 05/12/2014 01:38 PM, Divneil Wadhawan wrote:
> Hi Hans,
>
> Please find attached the patch. I hope its okay.
> I have only touched filed which were vb2 based in my understanding.
>
> Yeah! I was referring to the define as it's the easier way and also fulfilling my use case.
> However, I am looking forward for queue->depth kind of approach where driver can specify its own choice for max buffers.
>
> Regards,
> Divneil
> PS: I was on travel, hence the delay.
Sorry for the delay, I missed your patch.
It looks good, but you need to update a few more files:
include/media/davinci/vpfe_capture.h
drivers/media/platform/vivi-core.c
drivers/media/pci/saa7134/*
Regards,
Hans
next prev parent reply other threads:[~2014-07-04 7:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 9:37 vb2_reqbufs() is not allowing more than VIDEO_MAX_FRAME Divneil Wadhawan
2014-05-07 10:12 ` Hans Verkuil
2014-05-07 11:26 ` Divneil Wadhawan
2014-05-07 11:34 ` Hans Verkuil
[not found] ` <BAY176-W20DF4182FBC288F24380FCA9350@phx.gbl>
2014-07-04 6:51 ` Divneil Wadhawan
[not found] ` <BAY176-W960662BE81D5920B94F97A9350@phx.gbl>
2014-07-04 7:47 ` Hans Verkuil [this message]
2014-07-07 7:27 ` Divneil Wadhawan
2014-07-07 8:22 ` Hans Verkuil
2014-07-08 7:51 ` Hans Verkuil
2014-07-08 12:50 ` Kamil Debski
2014-07-17 8:57 ` Hans Verkuil
2014-07-21 6:03 ` Divneil Wadhawan
2014-07-21 7:11 ` Ricardo Ribalda Delgado
2014-09-21 10:46 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B65C2E.9040503@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=divneil@outlook.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).