From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:34517 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbaGHSgC (ORCPT ); Tue, 8 Jul 2014 14:36:02 -0400 Message-ID: <53BC3A0E.4060505@iki.fi> Date: Tue, 08 Jul 2014 21:35:58 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Fabian Frederick , linux-kernel@vger.kernel.org CC: Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: Re: [PATCH 1/1] dvb-frontends: remove unnecessary break after goto References: <1404840181-29822-1-git-send-email-fabf@skynet.be> In-Reply-To: <1404840181-29822-1-git-send-email-fabf@skynet.be> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Moikka Fabian! I have no reason to decline that patch (I will apply it) even it has hardly meaning. But is there now some new tool which warns that kind of issues? regards Atnti On 07/08/2014 08:23 PM, Fabian Frederick wrote: > Cc: Antti Palosaari > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Signed-off-by: Fabian Frederick > --- > drivers/media/dvb-frontends/af9013.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/af9013.c b/drivers/media/dvb-frontends/af9013.c > index fb504f1..ecf6388 100644 > --- a/drivers/media/dvb-frontends/af9013.c > +++ b/drivers/media/dvb-frontends/af9013.c > @@ -470,7 +470,6 @@ static int af9013_statistics_snr_result(struct dvb_frontend *fe) > break; > default: > goto err; > - break; > } > > for (i = 0; i < len; i++) { > -- http://palosaari.fi/