From: Antti Palosaari <crope@iki.fi>
To: shuah.kh@samsung.com,
"Mauro Carvalho Chehab (m.chehab@samsung.com)"
<m.chehab@samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: fix PCTV 461e tuner I2C binding
Date: Tue, 08 Jul 2014 21:51:53 +0300 [thread overview]
Message-ID: <53BC3DC9.7010606@iki.fi> (raw)
In-Reply-To: <53BBF858.30408@samsung.com>
On 07/08/2014 04:55 PM, Shuah Khan wrote:
> Moikka Antti,
>
> On 07/07/2014 09:45 PM, Antti Palosaari wrote:
>> Moikka Shuah
>>
>
>>> Why are we unregistering i2c devices and dvb in this resume path?
>>> Looks incorrect to me.
>>
>> I don't know. Original patch I send was a bit different and tuner was
>> removed only during em28xx_dvb_fini()
>>
>> https://patchwork.linuxtv.org/patch/22275/
>>
>
> Yes. That's what I suspected. My patch and yours got munged somehow.
> I will send a fix in.
There has been merge conflict and that is end result. None has reported
that bug so far. Likely it is very rare users suspend/resume these
devices as DVB suspend/resume has been largely broken always...
> btw: thanks for teaching me how to say hello in Finnish
:=)
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-07-08 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 23:34 fix PCTV 461e tuner I2C binding Shuah Khan
2014-07-08 3:45 ` Antti Palosaari
2014-07-08 13:55 ` Shuah Khan
2014-07-08 18:51 ` Antti Palosaari [this message]
2014-07-08 21:39 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC3DC9.7010606@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=shuah.kh@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).