Re: [PATCH 00/28] IPUv3 prep for video capture

[Hans Verkuil <hverkuil@xs4all.nl>]

Hi Steve,

I don't know what your plan is, but when you want to mainline this it is
the gpu subsystem that needs to review it. I noticed it wasn't cross-posted
to the dri-devel mailinglist.

I am a bit worried about the amount of v4l2-specific stuff that is going
into drivers/gpu/ipu-v3. Do things like csc and csi really belong there
instead of under drivers/media?

Let me know if this was just preliminary code, or if this was intended to
be the final code. I suspect the former.

Regards,

	Hans

On 06/26/2014 03:05 AM, Steve Longerbeam wrote:
> Hi Philip, Sascha,
> 
> Here is a rebased set of IPU patches that prepares for video capture
> support. Video capture is not included in this set. I've addressed
> all your IPU-specific concerns from the previous patch set, the
> major ones being:
> 
> - the IOMUXC control for CSI input selection has been removed. This
>   should be part of a future CSI media entity driver.
> 
> - the ipu-irt unit has been removed. Enabling the IRT module is
>   folded into ipu-ic unit. The ipu-ic unit is also cleaned up a bit.
> 
> - the ipu-csi APIs are consolidated/simplified.
> 
> - added CSI and IC base offsets for i.MX51/i.MX53.
> 
> 
> Steve Longerbeam (28):
>   ARM: dts: imx6qdl: Add ipu aliases
>   gpu: ipu-v3: Add ipu_get_num()
>   gpu: ipu-v3: Add functions to set CSI/IC source muxes
>   gpu: ipu-v3: Rename and add IDMAC channels
>   gpu: ipu-v3: Add units required for video capture
>   gpu: ipu-v3: smfc: Move enable/disable to ipu-smfc.c
>   gpu: ipu-v3: smfc: Convert to per-channel
>   gpu: ipu-v3: smfc: Add ipu_smfc_set_watermark()
>   gpu: ipu-v3: Add ipu_mbus_code_to_colorspace()
>   gpu: ipu-v3: Add rotation mode conversion utilities
>   gpu: ipu-v3: Add helper function checking if pixfmt is planar
>   gpu: ipu-v3: Move IDMAC channel names to imx-ipu-v3.h
>   gpu: ipu-v3: Add ipu_idmac_buffer_is_ready()
>   gpu: ipu-v3: Add ipu_idmac_clear_buffer()
>   gpu: ipu-v3: Add __ipu_idmac_reset_current_buffer()
>   gpu: ipu-v3: Add ipu_stride_to_bytes()
>   gpu: ipu-v3: Add ipu_idmac_enable_watermark()
>   gpu: ipu-v3: Add ipu_idmac_lock_enable()
>   gpu: ipu-v3: Add idmac channel linking support
>   gpu: ipu-v3: Add ipu-cpmem unit
>   staging: imx-drm: Convert to new ipu_cpmem API
>   gpu: ipu-cpmem: Add ipu_cpmem_set_block_mode()
>   gpu: ipu-cpmem: Add ipu_cpmem_set_axi_id()
>   gpu: ipu-cpmem: Add ipu_cpmem_set_rotation()
>   gpu: ipu-cpmem: Add second buffer support to ipu_cpmem_set_image()
>   gpu: ipu-v3: Add more planar formats support
>   gpu: ipu-cpmem: Add ipu_cpmem_dump()
>   gpu: ipu-v3: Add ipu_dump()
> 
>  arch/arm/boot/dts/imx6q.dtsi          |    1 +
>  arch/arm/boot/dts/imx6qdl.dtsi        |    1 +
>  drivers/gpu/ipu-v3/Makefile           |    3 +-
>  drivers/gpu/ipu-v3/ipu-common.c       | 1077 +++++++++++++++++++--------------
>  drivers/gpu/ipu-v3/ipu-cpmem.c        |  817 +++++++++++++++++++++++++
>  drivers/gpu/ipu-v3/ipu-csi.c          |  701 +++++++++++++++++++++
>  drivers/gpu/ipu-v3/ipu-ic.c           |  812 +++++++++++++++++++++++++
>  drivers/gpu/ipu-v3/ipu-prv.h          |  103 +++-
>  drivers/gpu/ipu-v3/ipu-smfc.c         |  156 ++++-
>  drivers/staging/imx-drm/ipuv3-plane.c |   16 +-
>  include/video/imx-ipu-v3.h            |  371 +++++++-----
>  11 files changed, 3389 insertions(+), 669 deletions(-)
>  create mode 100644 drivers/gpu/ipu-v3/ipu-cpmem.c
>  create mode 100644 drivers/gpu/ipu-v3/ipu-csi.c
>  create mode 100644 drivers/gpu/ipu-v3/ipu-ic.c
>