From: Antti Palosaari <crope@iki.fi>
To: Luis Alves <ljalvs@gmail.com>, Olli Salonen <olli.salonen@iki.fi>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] si2168: improve scanning performance by setting property 0301 with a value from Windows driver.
Date: Fri, 18 Jul 2014 00:46:26 +0300 [thread overview]
Message-ID: <53C84432.7050100@iki.fi> (raw)
In-Reply-To: <CAGj5WxCBwM3UZ1XW9aUez+nYaB46hxy6+NOWQqwdzFdd9aNq8A@mail.gmail.com>
On 07/17/2014 10:09 PM, Luis Alves wrote:
> This would be best done during init and not every time on set_frontend.
I am perfectly fine it is done during set_frontend(), even it is static
value. There were earlier tons of these 0x14 commands, including that
one. I removed all that were same as default (command reports back
existing value when new is set). It happens that Olli's Si2168-A30 chip
has different default value than Si2168-B40 I have.
init() is perfect place for enabling chip, power-up blocks, start
clocks, downloading firmware and loading "inittab". That command seems
to belong tuning process itself.
I will apply that.
regards
Antti
>
> Regards,
> Luis
>
> On Thu, Jul 17, 2014 at 7:43 PM, Olli Salonen <olli.salonen@iki.fi> wrote:
>> Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
>> ---
>> drivers/media/dvb-frontends/si2168.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c
>> index 0422925..56811e1 100644
>> --- a/drivers/media/dvb-frontends/si2168.c
>> +++ b/drivers/media/dvb-frontends/si2168.c
>> @@ -313,6 +313,13 @@ static int si2168_set_frontend(struct dvb_frontend *fe)
>> if (ret)
>> goto err;
>>
>> + memcpy(cmd.args, "\x14\x00\x01\x03\x0c\x00", 6);
>> + cmd.wlen = 6;
>> + cmd.rlen = 4;
>> + ret = si2168_cmd_execute(s, &cmd);
>> + if (ret)
>> + goto err;
>> +
>> memcpy(cmd.args, "\x85", 1);
>> cmd.wlen = 1;
>> cmd.rlen = 1;
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
http://palosaari.fi/
prev parent reply other threads:[~2014-07-17 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 18:43 [PATCH] si2168: improve scanning performance by setting property 0301 with a value from Windows driver Olli Salonen
2014-07-17 19:09 ` Luis Alves
2014-07-17 21:46 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C84432.7050100@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=ljalvs@gmail.com \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).