linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Olli Salonen <olli.salonen@iki.fi>,
	linux-media@vger.kernel.org, Luis Alves <ljalvs@gmail.com>
Subject: Re: [PATCH] si2157: Use name si2157_ops instead of si2157_tuner_ops (harmonize with si2168)
Date: Fri, 18 Jul 2014 18:25:12 +0300	[thread overview]
Message-ID: <53C93C58.80000@iki.fi> (raw)
In-Reply-To: <1405662072-26808-1-git-send-email-olli.salonen@iki.fi>

I will apply that, thanks!

Could you and also Luis pay attention to commit message in future 
patches. I have had practically fixed almost every commit message from 
your patches. Long one liner just like this one is not correct. It 
should be short subject line and then explained more in the commit 
message body. I tend ask myself questions "why" and "how" and then write 
commit message based answers of those questions.

regards
Antti

On 07/18/2014 08:41 AM, Olli Salonen wrote:
> Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
> ---
>   drivers/media/tuners/si2157.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
> index 329004f..4730f69 100644
> --- a/drivers/media/tuners/si2157.c
> +++ b/drivers/media/tuners/si2157.c
> @@ -277,7 +277,7 @@ err:
>   	return ret;
>   }
>
> -static const struct dvb_tuner_ops si2157_tuner_ops = {
> +static const struct dvb_tuner_ops si2157_ops = {
>   	.info = {
>   		.name           = "Silicon Labs Si2157/Si2158",
>   		.frequency_min  = 110000000,
> @@ -317,7 +317,7 @@ static int si2157_probe(struct i2c_client *client,
>   		goto err;
>
>   	fe->tuner_priv = s;
> -	memcpy(&fe->ops.tuner_ops, &si2157_tuner_ops,
> +	memcpy(&fe->ops.tuner_ops, &si2157_ops,
>   			sizeof(struct dvb_tuner_ops));
>
>   	i2c_set_clientdata(client, s);
>

-- 
http://palosaari.fi/

      parent reply	other threads:[~2014-07-18 15:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18  5:41 [PATCH] si2157: Use name si2157_ops instead of si2157_tuner_ops (harmonize with si2168) Olli Salonen
2014-07-18  9:32 ` Luis Alves
2014-07-18 15:25 ` Antti Palosaari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C93C58.80000@iki.fi \
    --to=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=ljalvs@gmail.com \
    --cc=olli.salonen@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).