From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] v4l: Clarify RGB666 pixel format definition
Date: Mon, 21 Jul 2014 23:43:16 +0200 [thread overview]
Message-ID: <53CD8974.20109@xs4all.nl> (raw)
In-Reply-To: <1405975150-9256-1-git-send-email-laurent.pinchart@ideasonboard.com>
On 07/21/2014 10:39 PM, Laurent Pinchart wrote:
> The RGB666 pixel format doesn't include an alpha channel. Document it as
> such.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../DocBook/media/v4l/pixfmt-packed-rgb.xml | 20 ++++++--------------
> 1 file changed, 6 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> index 32feac9..c47692a 100644
> --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
> @@ -330,20 +330,12 @@ colorspace <constant>V4L2_COLORSPACE_SRGB</constant>.</para>
> <entry></entry>
> <entry>r<subscript>1</subscript></entry>
> <entry>r<subscript>0</subscript></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> - <entry></entry>
> + <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
> + <entry>-</entry>
Just to clarify: BGR666 is a three byte format, not a four byte format?
If so, then:
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> </row>
> <row id="V4L2-PIX-FMT-BGR24">
> <entry><constant>V4L2_PIX_FMT_BGR24</constant></entry>
>
next prev parent reply other threads:[~2014-07-21 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 20:39 [PATCH] v4l: Clarify RGB666 pixel format definition Laurent Pinchart
2014-07-21 21:43 ` Hans Verkuil [this message]
2014-07-21 22:30 ` Laurent Pinchart
2014-07-21 22:44 ` Hans Verkuil
2014-09-09 13:18 ` Laurent Pinchart
2014-09-09 14:45 ` Sylwester Nawrocki
2014-10-29 11:45 ` Laurent Pinchart
2015-11-09 22:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CD8974.20109@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).