From: Hans Verkuil <hverkuil@xs4all.nl>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] v4l: Fix ARGB32 fourcc value in the documentation
Date: Tue, 22 Jul 2014 00:59:27 +0200 [thread overview]
Message-ID: <53CD9B4F.1010706@xs4all.nl> (raw)
In-Reply-To: <1562821.gYWjTNHcTz@avalon>
On 07/22/2014 12:46 AM, Laurent Pinchart wrote:
> On Tuesday 22 July 2014 00:45:05 Hans Verkuil wrote:
>> On 07/22/2014 12:41 AM, Laurent Pinchart wrote:
>>> The ARGB32 pixel format's fourcc value is defined to 'BA24' in the
>>> videodev2.h header, but documented as 'AX24'. Fix the documentation.
>>>
>>> Reported-by: Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>>
>> Reported-by or Acked-by? :-)
>>
>> Anyway:
>>
>> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> See ? git was predicting the future :-)
>
> Linus is getting grumpy about the amount of 3.16-rc fixes. I'm thus
> considering delaying this patch to 3.17. Any objection ?
No objection, the actual code is OK after all.
Hans
>
>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> ---
>>>
>>> Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
>>> b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml index
>>> 32feac9..4209542 100644
>>> --- a/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
>>> +++ b/Documentation/DocBook/media/v4l/pixfmt-packed-rgb.xml
>>> @@ -489,7 +489,7 @@ colorspace
>>> <constant>V4L2_COLORSPACE_SRGB</constant>.</para>>
>>> </row>
>>> <row id="V4L2-PIX-FMT-ARGB32">
>>> <entry><constant>V4L2_PIX_FMT_ARGB32</constant></entry>
>>> - <entry>'AX24'</entry>
>>> + <entry>'BA24'</entry>
>>> <entry></entry>
>>> <entry>a<subscript>7</subscript></entry>
>>> <entry>a<subscript>6</subscript></entry>
>
prev parent reply other threads:[~2014-07-21 22:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 22:41 [PATCH] v4l: Fix ARGB32 fourcc value in the documentation Laurent Pinchart
2014-07-21 22:45 ` Hans Verkuil
2014-07-21 22:46 ` Laurent Pinchart
2014-07-21 22:59 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CD9B4F.1010706@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox