* [PATCH] media: s5p_mfc: remove unnecessary calling to function video_devdata()
@ 2014-07-23 0:49 Zhaowei Yuan
2014-07-23 2:43 ` Joonyoung Shim
0 siblings, 1 reply; 4+ messages in thread
From: Zhaowei Yuan @ 2014-07-23 0:49 UTC (permalink / raw)
To: linux-media, k.debski, m.chehab, kyungmin.park, jtp.park
Cc: linux-samsung-soc, Zhaowei Yuan
Since we have get vdev by calling video_devdata() at the beginning of
s5p_mfc_open(), we should just use vdev instead of calling video_devdata()
again in the following code.
Change-Id: I869051762d33b50a7c0dbc8149b072e70b89c6b9
Signed-off-by: Zhaowei Yuan <zhaowei.yuan@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index d57b306..d508cbc 100755
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -709,7 +709,7 @@ static int s5p_mfc_open(struct file *file)
ret = -ENOMEM;
goto err_alloc;
}
- v4l2_fh_init(&ctx->fh, video_devdata(file));
+ v4l2_fh_init(&ctx->fh, vdev);
file->private_data = &ctx->fh;
v4l2_fh_add(&ctx->fh);
ctx->dev = dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: s5p_mfc: remove unnecessary calling to function video_devdata()
2014-07-23 0:49 [PATCH] media: s5p_mfc: remove unnecessary calling to function video_devdata() Zhaowei Yuan
@ 2014-07-23 2:43 ` Joonyoung Shim
0 siblings, 0 replies; 4+ messages in thread
From: Joonyoung Shim @ 2014-07-23 2:43 UTC (permalink / raw)
To: Zhaowei Yuan, m.chehab
Cc: linux-media, k.debski, kyungmin.park, jtp.park, linux-samsung-soc
Hi Zhaowei,
On 07/23/2014 09:49 AM, Zhaowei Yuan wrote:
> Since we have get vdev by calling video_devdata() at the beginning of
> s5p_mfc_open(), we should just use vdev instead of calling video_devdata()
> again in the following code.
>
> Change-Id: I869051762d33b50a7c0dbc8149b072e70b89c6b9
Please don't put this in patch when you submit at upstream. Change-Id
means nothing to us.
> Signed-off-by: Zhaowei Yuan <zhaowei.yuan@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index d57b306..d508cbc 100755
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -709,7 +709,7 @@ static int s5p_mfc_open(struct file *file)
> ret = -ENOMEM;
> goto err_alloc;
> }
> - v4l2_fh_init(&ctx->fh, video_devdata(file));
> + v4l2_fh_init(&ctx->fh, vdev);
> file->private_data = &ctx->fh;
> v4l2_fh_add(&ctx->fh);
> ctx->dev = dev;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] media: s5p_mfc: remove unnecessary calling to function video_devdata()
@ 2014-07-23 4:06 Zhaowei Yuan
2014-07-29 13:08 ` Sylwester Nawrocki
0 siblings, 1 reply; 4+ messages in thread
From: Zhaowei Yuan @ 2014-07-23 4:06 UTC (permalink / raw)
To: linux-media, k.debski, m.chehab, kyungmin.park, jtp.park
Cc: linux-samsung-soc
Since we have get vdev by calling video_devdata() at the beginning of
s5p_mfc_open(), we should just use vdev instead of calling video_devdata()
again in the following code.
Signed-off-by: Zhaowei Yuan <zhaowei.yuan@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index d57b306..d508cbc 100755
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -709,7 +709,7 @@ static int s5p_mfc_open(struct file *file)
ret = -ENOMEM;
goto err_alloc;
}
- v4l2_fh_init(&ctx->fh, video_devdata(file));
+ v4l2_fh_init(&ctx->fh, vdev);
file->private_data = &ctx->fh;
v4l2_fh_add(&ctx->fh);
ctx->dev = dev;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-29 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 0:49 [PATCH] media: s5p_mfc: remove unnecessary calling to function video_devdata() Zhaowei Yuan
2014-07-23 2:43 ` Joonyoung Shim
-- strict thread matches above, loose matches on Subject: below --
2014-07-23 4:06 Zhaowei Yuan
2014-07-29 13:08 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).