From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Zhaowei Yuan <zhaowei.yuan@samsung.com>
Cc: linux-media@vger.kernel.org, k.debski@samsung.com,
m.chehab@samsung.com, kyungmin.park@samsung.com,
jtp.park@samsung.com, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] media: s5p_mfc: Check the right pointer after allocation
Date: Tue, 29 Jul 2014 15:23:18 +0200 [thread overview]
Message-ID: <53D7A046.1090809@samsung.com> (raw)
In-Reply-To: <1406088312-5205-1-git-send-email-zhaowei.yuan@samsung.com>
On 23/07/14 06:05, Zhaowei Yuan wrote:
> It should be bank2_virt to be checked after dma allocation
> instead of dev->fw_virt_addr.
This patch is not applicable to the media master branch [1].
Additionally, AFAICS dma_alloc_coherent return value should be tested
for NULL, rather than for ERR_PTR() value. It seems you have some
incorrect changes in your tree, which this patch depends on.
[1] http://git.linuxtv.org/cgit.cgi/media_tree.git
next prev parent reply other threads:[~2014-07-29 13:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 4:05 [PATCH] media: s5p_mfc: Check the right pointer after allocation Zhaowei Yuan
2014-07-29 13:23 ` Sylwester Nawrocki [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-23 0:48 Zhaowei Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D7A046.1090809@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=zhaowei.yuan@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).