From: Hans Verkuil <hverkuil@xs4all.nl>
To: Nicholas Krause <xerofoify@gmail.com>, udovdh@xs4all.nl
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] v4l2: Change call of function in videobuf2-core.c
Date: Mon, 04 Aug 2014 07:03:14 +0200 [thread overview]
Message-ID: <53DF1412.9010506@xs4all.nl> (raw)
In-Reply-To: <1407122751-30689-1-git-send-email-xerofoify@gmail.com>
On 08/04/2014 05:25 AM, Nicholas Krause wrote:
> This patch changes the call of vb2_buffer_core to use VB2_BUFFER_STATE_ACTIVE
> inside the for instead of not setting in correctly to VB2_BUFFER_STATE_ERROR.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Dunno what's going on here after reading Dave Airlie's reply, but:
Nacked-by: Hans Verkuil <hans.verkuil@cisco.com>
It's clearly wrong and if you get here at all you have a driver bug anyway. That
WARN_ON is there for a reason. Your driver isn't returning buffers correctly in
stop_streaming or in start_streaming if start_streaming fails with an error.
Regards,
Hans
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index 7c4489c..08e478b 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -2115,7 +2115,7 @@ static void __vb2_queue_cancel(struct vb2_queue *q)
> if (WARN_ON(atomic_read(&q->owned_by_drv_count))) {
> for (i = 0; i < q->num_buffers; ++i)
> if (q->bufs[i]->state == VB2_BUF_STATE_ACTIVE)
> - vb2_buffer_done(q->bufs[i], VB2_BUF_STATE_ERROR);
> + vb2_buffer_done(q->bufs[i], VB2_BUF_STATE_ACTIVE);
> /* Must be zero now */
> WARN_ON(atomic_read(&q->owned_by_drv_count));
> }
>
next prev parent reply other threads:[~2014-08-04 5:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 3:25 [PATCH] v4l2: Change call of function in videobuf2-core.c Nicholas Krause
2014-08-04 4:07 ` Dave Airlie
2014-08-04 5:03 ` Hans Verkuil [this message]
2014-08-04 5:07 ` Nick Krause
2014-08-04 5:38 ` Dave Airlie
2014-08-04 5:43 ` Nick Krause
2014-08-04 5:50 ` Nick Krause
2014-08-04 5:54 ` Dave Airlie
2014-08-04 5:59 ` Nick Krause
2014-08-04 11:48 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DF1412.9010506@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=udovdh@xs4all.nl \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).