Re: [PATCH for v3.17 2/2] vb2: fix vb2 state check when start_streaming fails

[Hans Verkuil <hverkuil@xs4all.nl>]

On 08/04/2014 12:44 PM, Laurent Pinchart wrote:
> Hi Hans,
> 
> Thank you for the patch.
> 
> On Monday 04 August 2014 12:27:12 Hans Verkuil wrote:
>> From: Hans Verkuil <hans.verkuil@cisco.com>
>>
>> Commit bd994ddb2a12a3ff48cd549ec82cdceaea9614df (vb2: Fix stream start and
>> buffer completion race) broke the buffer state check in vb2_buffer_done.
>>
>> So accept all three possible states there since I can no longer tell the
>> difference between vb2_buffer_done called from start_streaming or from
>> elsewhere.
>>
>> Instead add a WARN_ON at the end of start_streaming that will check whether
>> any buffers were added to the done list, since that implies that the wrong
>> state was used as well.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>> Cc: stable@vger.kernel.org      # for v3.15 and up
>> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Given that I've introduced a few vb2 bugs I hope my review still has some 
> value :-)

Since I reviewed your original patch as well, I'm not going to throw stones at
you :-)

Regards,

	Hans