From: Hans Verkuil <hverkuil@xs4all.nl>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/1] v4l: Event documentation fixes
Date: Thu, 07 Aug 2014 08:50:16 +0200 [thread overview]
Message-ID: <53E321A8.9070304@xs4all.nl> (raw)
In-Reply-To: <1407307928-13652-1-git-send-email-sakari.ailus@linux.intel.com>
On 08/06/2014 08:52 AM, Sakari Ailus wrote:
> Constify event type constants and correct motion detection event number
> (it's 6, not 5).
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> Thanks for the review, Hans!
>
> Since v1:
>
> - No line breaks between <constant> and </constant>. No other changes.
>
> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> index cb77325..b036f89 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> @@ -76,21 +76,22 @@
> <entry></entry>
> <entry>&v4l2-event-vsync;</entry>
> <entry><structfield>vsync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_VSYNC.
> + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-ctrl;</entry>
> <entry><structfield>ctrl</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_CTRL.
> + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-frame-sync;</entry>
> <entry><structfield>frame_sync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
> + <entry>Event data for event
> + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry>
> </row>
> <row>
> <entry></entry>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> index 9f60956..d7c9365 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> @@ -176,7 +176,7 @@
> </row>
> <row>
> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
> - <entry>5</entry>
> + <entry>6</entry>
> <entry>
> <para>Triggered whenever the motion detection state for one or more of the regions
> changes. This event has a &v4l2-event-motion-det; associated with it.</para>
>
next prev parent reply other threads:[~2014-08-07 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 6:37 [PATCH 1/1] v4l: Event documentation fixes Sakari Ailus
2014-08-06 6:43 ` Hans Verkuil
2014-08-06 6:52 ` [PATCH v2 " Sakari Ailus
2014-08-06 6:58 ` Hans Verkuil
2014-08-07 6:50 ` Hans Verkuil [this message]
2014-08-07 6:51 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E321A8.9070304@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox