From: Matthias Schwarzott <zzam@gentoo.org>
To: Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
"nibble.max" <nibble.max@gmail.com>
Cc: linux-media <linux-media@vger.kernel.org>,
"olli.salonen" <olli.salonen@iki.fi>
Subject: Re: [PATCH] m88ts2022: fix high symbol rate transponders missing on 32bit platform.
Date: Sat, 16 Aug 2014 21:26:56 +0200 [thread overview]
Message-ID: <53EFB080.50905@gentoo.org> (raw)
In-Reply-To: <53EF5457.5080808@iki.fi>
On 16.08.2014 14:53, Antti Palosaari wrote:
>
>
> I will look that more carefully on end of next week, go through possible
> symbol rates and rounding errors.
>
> Maybe it should be something like that (didn't test any way, may not
> even compile):
> f_3db_hz = div_u64((u64) (c->symbol_rate * 135), 200);
>
In this case c->symbol_rate * 135 is still 32bits wide, but maybe signed
because 135 is signed.
So there will be an overflow on 32bit platforms at symbol rates equal to
15907287.
So better cast symbol_rate to u64 before.
Matthias
next prev parent reply other threads:[~2014-08-16 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 6:12 [PATCH] m88ts2022: fix high symbol rate transponders missing on 32bit platform nibble.max
2014-08-16 12:38 ` Mauro Carvalho Chehab
2014-08-16 12:53 ` Antti Palosaari
2014-08-16 19:26 ` Matthias Schwarzott [this message]
2014-08-16 13:31 ` Re: [PATCH] m88ts2022: fix high symbol rate transponders missing on32bit platform Max Xiang
-- strict thread matches above, loose matches on Subject: below --
2014-08-16 6:26 [PATCH] m88ts2022: fix high symbol rate transponders missing on 32bit platform nibble.max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EFB080.50905@gentoo.org \
--to=zzam@gentoo.org \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=nibble.max@gmail.com \
--cc=olli.salonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).