From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Pawel Osciak <pawel@osciak.com>
Subject: Re: [RFC PATCH] vb2: use pr_info instead of pr_debug
Date: Mon, 18 Aug 2014 11:13:57 +0200 [thread overview]
Message-ID: <53F1C3D5.6030606@samsung.com> (raw)
In-Reply-To: <53E4C996.4060001@xs4all.nl>
Hello,
On 2014-08-08 14:59, Hans Verkuil wrote:
> Modern kernels enable dynamic printk support, which is fine, except when it is
> combined with a debug module option. Enabling debug in videobuf2-core now produces
> no debugging unless it is also enabled through the dynamic printk support in debugfs.
>
> Either use a debug module option + pr_info, or use pr_debug without a debug module
> option. In this case the fact that you can set various debug levels is very useful,
> so I believe that for videobuf2-core.c we should use pr_info.
>
> The mix of the two is very confusing: I've spent too much time already trying to
> figure out why I am not seeing any debug output in the kernel log when I do:
>
> echo 1 >/sys/modules/videobuf2_core/parameters/debug
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index 0e3d927..0b59735 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -36,7 +36,7 @@ module_param(debug, int, 0644);
> #define dprintk(level, fmt, arg...) \
> do { \
> if (debug >= level) \
> - pr_debug("vb2: %s: " fmt, __func__, ## arg); \
> + pr_info("vb2: %s: " fmt, __func__, ## arg); \
> } while (0)
>
> #ifdef CONFIG_VIDEO_ADV_DEBUG
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2014-08-18 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 12:59 [RFC PATCH] vb2: use pr_info instead of pr_debug Hans Verkuil
2014-08-18 9:13 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F1C3D5.6030606@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=pawel@osciak.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).