From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cantor2.suse.de ([195.135.220.15]:35166 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbaHVRE5 (ORCPT ); Fri, 22 Aug 2014 13:04:57 -0400 Message-ID: <53F77835.7050406@suse.com> Date: Fri, 22 Aug 2014 13:04:53 -0400 From: Jeff Mahoney MIME-Version: 1.0 To: Antti Palosaari CC: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select References: <1408726929-3924-1-git-send-email-crope@iki.fi> In-Reply-To: <1408726929-3924-1-git-send-email-crope@iki.fi> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: > We should not select SPI bus when sub-driver auto-select is > selected. That option is meant for auto-selecting all possible > ancillary drivers used for selected board driver. Ancillary > drivers should define needed dependencies itself. > > I2C and I2C_MUX are still selected here for a reason described on > commit 347f7a3763601d7b466898d1f10080b7083ac4a3 > > Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a > > Reported-by: Jeff Mahoney > Signed-off-by: Antti Palosaari > --- > drivers/media/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig > index f60bad4..3c89fcb 100644 > --- a/drivers/media/Kconfig > +++ b/drivers/media/Kconfig > @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT > depends on HAS_IOMEM > select I2C > select I2C_MUX > - select SPI > default y > help > By default, a media driver auto-selects all possible ancillary FWIW, in the patch I used locally, I also did a 'select SPI' in the MSI2500 driver since it wouldn't otherwise be obvious that a USB device depends on SPI. -Jeff -- Jeff Mahoney SUSE Labs