From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from casper.infradead.org ([85.118.1.10]:59162 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbaHVXeR (ORCPT ); Fri, 22 Aug 2014 19:34:17 -0400 Message-ID: <53F7D374.3050804@infradead.org> Date: Fri, 22 Aug 2014 16:34:12 -0700 From: Randy Dunlap MIME-Version: 1.0 To: Jeff Mahoney , Antti Palosaari CC: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select References: <1408726929-3924-1-git-send-email-crope@iki.fi> <53F77835.7050406@suse.com> In-Reply-To: <53F77835.7050406@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 08/22/14 10:04, Jeff Mahoney wrote: > On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote: >> We should not select SPI bus when sub-driver auto-select is >> selected. That option is meant for auto-selecting all possible >> ancillary drivers used for selected board driver. Ancillary >> drivers should define needed dependencies itself. >> >> I2C and I2C_MUX are still selected here for a reason described on >> commit 347f7a3763601d7b466898d1f10080b7083ac4a3 >> >> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a >> >> Reported-by: Jeff Mahoney >> Signed-off-by: Antti Palosaari >> --- >> drivers/media/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig >> index f60bad4..3c89fcb 100644 >> --- a/drivers/media/Kconfig >> +++ b/drivers/media/Kconfig >> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT >> depends on HAS_IOMEM >> select I2C >> select I2C_MUX >> - select SPI >> default y >> help >> By default, a media driver auto-selects all possible ancillary > > FWIW, in the patch I used locally, I also did a 'select SPI' in the > MSI2500 driver since it wouldn't otherwise be obvious that a USB device > depends on SPI. It already has depends on SPI. That should be enough. -- ~Randy