* [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select
@ 2014-08-22 17:02 Antti Palosaari
2014-08-22 17:04 ` Jeff Mahoney
0 siblings, 1 reply; 4+ messages in thread
From: Antti Palosaari @ 2014-08-22 17:02 UTC (permalink / raw)
To: linux-media; +Cc: Jeff Mahoney, linux-kernel, Antti Palosaari
We should not select SPI bus when sub-driver auto-select is
selected. That option is meant for auto-selecting all possible
ancillary drivers used for selected board driver. Ancillary
drivers should define needed dependencies itself.
I2C and I2C_MUX are still selected here for a reason described on
commit 347f7a3763601d7b466898d1f10080b7083ac4a3
Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a
Reported-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
---
drivers/media/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index f60bad4..3c89fcb 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT
depends on HAS_IOMEM
select I2C
select I2C_MUX
- select SPI
default y
help
By default, a media driver auto-selects all possible ancillary
--
http://palosaari.fi/
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select
2014-08-22 17:02 [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select Antti Palosaari
@ 2014-08-22 17:04 ` Jeff Mahoney
2014-08-22 23:34 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Mahoney @ 2014-08-22 17:04 UTC (permalink / raw)
To: Antti Palosaari; +Cc: linux-kernel, linux-media
On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote:
> We should not select SPI bus when sub-driver auto-select is
> selected. That option is meant for auto-selecting all possible
> ancillary drivers used for selected board driver. Ancillary
> drivers should define needed dependencies itself.
>
> I2C and I2C_MUX are still selected here for a reason described on
> commit 347f7a3763601d7b466898d1f10080b7083ac4a3
>
> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a
>
> Reported-by: Jeff Mahoney <jeffm@suse.com>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
> ---
> drivers/media/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index f60bad4..3c89fcb 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT
> depends on HAS_IOMEM
> select I2C
> select I2C_MUX
> - select SPI
> default y
> help
> By default, a media driver auto-selects all possible ancillary
FWIW, in the patch I used locally, I also did a 'select SPI' in the
MSI2500 driver since it wouldn't otherwise be obvious that a USB device
depends on SPI.
-Jeff
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select
2014-08-22 17:04 ` Jeff Mahoney
@ 2014-08-22 23:34 ` Randy Dunlap
2014-08-23 0:06 ` Jeff Mahoney
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2014-08-22 23:34 UTC (permalink / raw)
To: Jeff Mahoney, Antti Palosaari; +Cc: linux-kernel, linux-media
On 08/22/14 10:04, Jeff Mahoney wrote:
> On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote:
>> We should not select SPI bus when sub-driver auto-select is
>> selected. That option is meant for auto-selecting all possible
>> ancillary drivers used for selected board driver. Ancillary
>> drivers should define needed dependencies itself.
>>
>> I2C and I2C_MUX are still selected here for a reason described on
>> commit 347f7a3763601d7b466898d1f10080b7083ac4a3
>>
>> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a
>>
>> Reported-by: Jeff Mahoney <jeffm@suse.com>
>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>> ---
>> drivers/media/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
>> index f60bad4..3c89fcb 100644
>> --- a/drivers/media/Kconfig
>> +++ b/drivers/media/Kconfig
>> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT
>> depends on HAS_IOMEM
>> select I2C
>> select I2C_MUX
>> - select SPI
>> default y
>> help
>> By default, a media driver auto-selects all possible ancillary
>
> FWIW, in the patch I used locally, I also did a 'select SPI' in the
> MSI2500 driver since it wouldn't otherwise be obvious that a USB device
> depends on SPI.
It already has depends on SPI. That should be enough.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select
2014-08-22 23:34 ` Randy Dunlap
@ 2014-08-23 0:06 ` Jeff Mahoney
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Mahoney @ 2014-08-23 0:06 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, linux-media, Antti Palosaari
On Fri Aug 22 19:34:12 2014, Randy Dunlap wrote:
> On 08/22/14 10:04, Jeff Mahoney wrote:
>> On Fri Aug 22 13:02:09 2014, Antti Palosaari wrote:
>>> We should not select SPI bus when sub-driver auto-select is
>>> selected. That option is meant for auto-selecting all possible
>>> ancillary drivers used for selected board driver. Ancillary
>>> drivers should define needed dependencies itself.
>>>
>>> I2C and I2C_MUX are still selected here for a reason described on
>>> commit 347f7a3763601d7b466898d1f10080b7083ac4a3
>>>
>>> Reverts commit e4462ffc1602d9df21c00a0381dca9080474e27a
>>>
>>> Reported-by: Jeff Mahoney <jeffm@suse.com>
>>> Signed-off-by: Antti Palosaari <crope@iki.fi>
>>> ---
>>> drivers/media/Kconfig | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
>>> index f60bad4..3c89fcb 100644
>>> --- a/drivers/media/Kconfig
>>> +++ b/drivers/media/Kconfig
>>> @@ -182,7 +182,6 @@ config MEDIA_SUBDRV_AUTOSELECT
>>> depends on HAS_IOMEM
>>> select I2C
>>> select I2C_MUX
>>> - select SPI
>>> default y
>>> help
>>> By default, a media driver auto-selects all possible ancillary
>>
>> FWIW, in the patch I used locally, I also did a 'select SPI' in the
>> MSI2500 driver since it wouldn't otherwise be obvious that a USB device
>> depends on SPI.
>
> It already has depends on SPI. That should be enough.
>
Yeah. My point was more that if you want support for that device, you'd
have to know it uses SPI internally already.
-Jeff
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-23 0:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 17:02 [PATCH] Kconfig: do not select SPI bus on sub-driver auto-select Antti Palosaari
2014-08-22 17:04 ` Jeff Mahoney
2014-08-22 23:34 ` Randy Dunlap
2014-08-23 0:06 ` Jeff Mahoney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).