linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available
@ 2014-08-26 17:25 Mark Brown
  2014-08-26 18:58 ` Randy Dunlap
  2014-08-26 19:20 ` Randy Dunlap
  0 siblings, 2 replies; 11+ messages in thread
From: Mark Brown @ 2014-08-26 17:25 UTC (permalink / raw)
  To: Peter Foley, Randy Dunlap, Mauro Carvalho Chehab, Hans Verkuil
  Cc: linux-media, linux-doc, linaro-kernel, Mark Brown

From: Mark Brown <broonie@linaro.org>

Currently arm64 does not support PCI but it does support v4l2. Since the
PCI skeleton driver is built unconditionally as a module with no dependency
on PCI this causes build failures for arm64 allmodconfig. Fix this by
defining a symbol VIDEO_PCI_SKELETON for the skeleton and conditionalising
the build on that.

Signed-off-by: Mark Brown <broonie@linaro.org>
---

The patch adding the Makefile was added to the Documentation tree,
either it should be reverted or something like this added on top.

 Documentation/video4linux/Makefile | 2 +-
 drivers/media/v4l2-core/Kconfig    | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/video4linux/Makefile b/Documentation/video4linux/Makefile
index d58101e788fc..65a351d75c95 100644
--- a/Documentation/video4linux/Makefile
+++ b/Documentation/video4linux/Makefile
@@ -1 +1 @@
-obj-m := v4l2-pci-skeleton.o
+obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
index 9ca0f8d59a14..2b368f711c9e 100644
--- a/drivers/media/v4l2-core/Kconfig
+++ b/drivers/media/v4l2-core/Kconfig
@@ -25,6 +25,13 @@ config VIDEO_FIXED_MINOR_RANGES
 
 	  When in doubt, say N.
 
+config VIDEO_PCI_SKELETON
+	tristate "Skeleton PCI V4L2 driver"
+	depends on PCI && COMPILE_TEST
+	---help---
+	  Enable build of the skeleton PCI driver, used as a reference
+	  when developign new drivers.
+
 # Used by drivers that need tuner.ko
 config VIDEO_TUNER
 	tristate
-- 
2.1.0.rc1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available
@ 2014-08-26 16:38 Mark Brown
  2014-08-26 16:56 ` Hans Verkuil
  2014-08-26 21:01 ` Hans Verkuil
  0 siblings, 2 replies; 11+ messages in thread
From: Mark Brown @ 2014-08-26 16:38 UTC (permalink / raw)
  To: Mauro Carvalho Chehab, Hans Verkuil
  Cc: linux-media, linaro-kernel, Mark Brown

From: Mark Brown <broonie@linaro.org>

Currently arm64 does not support PCI but it does support v4l2. Since the
PCI skeleton driver is built unconditionally as a module with no dependency
on PCI this causes build failures for arm64 allmodconfig. Fix this by
defining a symbol VIDEO_PCI_SKELETON for the skeleton and conditionalising
the build on that.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 Documentation/video4linux/Makefile | 2 +-
 drivers/media/v4l2-core/Kconfig    | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/video4linux/Makefile b/Documentation/video4linux/Makefile
index d58101e788fc..65a351d75c95 100644
--- a/Documentation/video4linux/Makefile
+++ b/Documentation/video4linux/Makefile
@@ -1 +1 @@
-obj-m := v4l2-pci-skeleton.o
+obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
index 9ca0f8d59a14..2b368f711c9e 100644
--- a/drivers/media/v4l2-core/Kconfig
+++ b/drivers/media/v4l2-core/Kconfig
@@ -25,6 +25,13 @@ config VIDEO_FIXED_MINOR_RANGES
 
 	  When in doubt, say N.
 
+config VIDEO_PCI_SKELETON
+	tristate "Skeleton PCI V4L2 driver"
+	depends on PCI && COMPILE_TEST
+	---help---
+	  Enable build of the skeleton PCI driver, used as a reference
+	  when developign new drivers.
+
 # Used by drivers that need tuner.ko
 config VIDEO_TUNER
 	tristate
-- 
2.1.0.rc1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2014-08-27  7:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-26 17:25 [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available Mark Brown
2014-08-26 18:58 ` Randy Dunlap
2014-08-26 19:20 ` Randy Dunlap
2014-08-26 19:26   ` Mark Brown
2014-08-26 19:59     ` Randy Dunlap
2014-08-26 20:08       ` Randy Dunlap
2014-08-27  7:09         ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2014-08-26 16:38 Mark Brown
2014-08-26 16:56 ` Hans Verkuil
2014-08-26 17:22   ` Mark Brown
2014-08-26 21:01 ` Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).