From: Randy Dunlap <rdunlap@infradead.org>
To: Mark Brown <broonie@kernel.org>
Cc: Peter Foley <pefoley2@pefoley.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, linux-doc@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available
Date: Tue, 26 Aug 2014 12:59:06 -0700 [thread overview]
Message-ID: <53FCE70A.6000907@infradead.org> (raw)
In-Reply-To: <20140826192624.GN17528@sirena.org.uk>
On 08/26/14 12:26, Mark Brown wrote:
> On Tue, Aug 26, 2014 at 12:20:54PM -0700, Randy Dunlap wrote:
>> On 08/26/14 10:25, Mark Brown wrote:
>
>>> index d58101e788fc..65a351d75c95 100644
>>> --- a/Documentation/video4linux/Makefile
>>> +++ b/Documentation/video4linux/Makefile
>>> @@ -1 +1 @@
>>> -obj-m := v4l2-pci-skeleton.o
>>> +obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
>>> diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
>
>>> +config VIDEO_PCI_SKELETON
>>> + tristate "Skeleton PCI V4L2 driver"
>>> + depends on PCI && COMPILE_TEST
>
>> && ?? No, don't require COMPILE_TEST.
>
> That's a very deliberate choice. There's no reason I can see to build
> this code other than to check that it builds, it's reference code rather
> than something that someone is expected to actually use in their system.
> This seems like a perfect candidate for COMPILE_TEST.
>
>> However, PCI || COMPILE_TEST would allow it to build on arm64
>> if COMPILE_TEST is enabled, guaranteeing build errors.
>> Is that what should happen? I suppose so...
>
> No, it's not - if it's going to depend on COMPILE_TEST at all it need to
> be a hard dependency.
How about just drop COMPILE_TEST? This code only builds if someone enabled
BUILD_DOCSRC. That should be enough (along with PCI and some VIDEO kconfig
symbols) to qualify it.
--
~Randy
next prev parent reply other threads:[~2014-08-26 19:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 17:25 [PATCH] [media] v4l2-pci-skeleton: Only build if PCI is available Mark Brown
2014-08-26 18:58 ` Randy Dunlap
2014-08-26 19:20 ` Randy Dunlap
2014-08-26 19:26 ` Mark Brown
2014-08-26 19:59 ` Randy Dunlap [this message]
2014-08-26 20:08 ` Randy Dunlap
2014-08-27 7:09 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2014-08-26 16:38 Mark Brown
2014-08-26 16:56 ` Hans Verkuil
2014-08-26 17:22 ` Mark Brown
2014-08-26 21:01 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCE70A.6000907@infradead.org \
--to=rdunlap@infradead.org \
--cc=broonie@kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pefoley2@pefoley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).