Re: [PATCH 7/9] media: qcom: camss: change internals of endpoint parsing to fwnode handling

[Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>]

Hi Bryan.

On 6/13/25 12:30, Bryan O'Donoghue wrote:
> On 13/05/2025 15:23, Vladimir Zapolskiy wrote:
>> +	fwnode_graph_for_each_endpoint(fwnode, ep) {
>>    		struct camss_async_subdev *csd;
>> +		struct fwnode_handle *remote;
>>
>> -		if (!of_device_is_available(node))
>> -			continue;
> 
> The change to fwnode seems fine I think but, either leave the
> of_device_is_available() check as-is or move its removal to a separate
> patch.
> 
> Changes should be as granular as possible.
> 

The change from OF handling to fwnode handling assumes that there is
no more room left for of_device_is_available() calls, it passes away.

of_device_is_available() here is useless, CAMSS ports are not devices
and they are not disabled in board dts.

--
Best wishes,
Vladimir