From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: linux-media@vger.kernel.org
Cc: k.debski@samsung.com
Subject: Bug: s5p-mfc should allow multiple call to REQBUFS before we start streaming
Date: Fri, 29 Aug 2014 09:46:50 -0400 [thread overview]
Message-ID: <5400844A.5030603@collabora.com> (raw)
Hi Kamil,
after a discussion on IRC, we concluded that s5p-mfc have this bug that
disallow multiple reqbufs calls before streaming. This has the impact
that it forces to call REQBUFS(0) before setting the new number of
buffers during re-negotiation, and is against the spec too.
As an example, in reqbufs_output() REQBUFS is only allowed in QUEUE_FREE
state, and setting buffers exits this state. We think that the call to
<http://lxr.free-electrons.com/ident?i=reqbufs_output>s5p_mfc_open_mfc_inst()
should be post-poned until STREAMON is called.
<http://lxr.free-electrons.com/ident?i=reqbufs_output>
cheers,
Nicolas
<http://lxr.free-electrons.com/ident?i=reqbufs_output>
next reply other threads:[~2014-08-29 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 13:46 Nicolas Dufresne [this message]
2014-09-01 9:43 ` s5p-mfc should allow multiple call to REQBUFS before we start streaming Kamil Debski
2014-09-01 15:45 ` Nicolas Dufresne
2014-09-02 9:02 ` Kamil Debski
2014-09-02 9:29 ` Hans Verkuil
2014-09-02 10:38 ` Kamil Debski
2014-09-02 12:02 ` Nicolas Dufresne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5400844A.5030603@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).