From: Antti Palosaari <crope@iki.fi>
To: Akihiro TSUKADA <tskd08@gmail.com>,
Matthias Schwarzott <zzam@gentoo.org>,
linux-media@vger.kernel.org
Cc: m.chehab@samsung.com
Subject: Re: [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator
Date: Sun, 31 Aug 2014 22:48:14 +0300 [thread overview]
Message-ID: <54037BFE.60606@iki.fi> (raw)
In-Reply-To: <540323F0.90809@gmail.com>
On 08/31/2014 04:32 PM, Akihiro TSUKADA wrote:
> Hi Matthias,
> thanks for the comment.
>
>> it sounds wrong to export a second function besides tc90522_attach.
>> This way there is a hard dependency of the bridge driver to the demod
>> driver.
>> In this case it is the only possible demod, but in general it violates
>> the design of demod drivers and their connection to bridge drivers.
>
> I agree. I missed that point.
>
>>
>> si2168_probe at least has a solution for this:
>> Write the pointer to the new i2c adapter into location stored in "struct
>> i2c_adapter **" in the config structure.
>
> I'll look into the si2168 code and update tc90522 in v3.
Also, I would like to see all new drivers (demod and tuner) implemented
as a standard kernel I2C drivers (or any other bus). I have converted
already quite many drivers, si2168, si2157, m88ds3103, m88ts2022,
it913x, tda18212, ...
When drivers are using proper kernel driver models, it allows using
kernel services. For example dev_ / pr_ logging (it does not work
properly without), RegMap API, I2C client, I2C multiplex, and so...
Here is few recent examples:
https://patchwork.linuxtv.org/patch/25495/
https://patchwork.linuxtv.org/patch/25152/
https://patchwork.linuxtv.org/patch/25146/
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-08-31 19:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 15:29 [PATCH v2 0/5] dvb: Add support for PT3 ISDB-S/T card tskd08
2014-08-27 15:29 ` [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5 tskd08
2014-08-27 18:09 ` Antti Palosaari
2014-08-28 9:07 ` Akihiro TSUKADA
2014-08-29 1:05 ` Antti Palosaari
2014-08-29 10:45 ` Akihiro TSUKADA
2014-09-06 2:09 ` Antti Palosaari
2014-09-06 2:51 ` Mauro Carvalho Chehab
2014-09-06 2:54 ` Mauro Carvalho Chehab
2014-09-06 3:10 ` Antti Palosaari
2014-09-06 3:17 ` Mauro Carvalho Chehab
2014-09-06 3:34 ` Antti Palosaari
2014-09-06 12:35 ` Mauro Carvalho Chehab
2014-09-06 4:08 ` Akihiro TSUKADA
2014-09-06 10:36 ` Antti Palosaari
2014-09-06 12:49 ` Mauro Carvalho Chehab
2014-09-06 16:24 ` Malcolm Priestley
2014-09-06 16:31 ` Malcolm Priestley
2014-09-06 21:37 ` Malcolm Priestley
2014-09-06 22:37 ` Mauro Carvalho Chehab
2014-09-06 23:38 ` Antti Palosaari
2014-09-07 9:35 ` Malcolm Priestley
2014-08-27 15:29 ` [PATCH v2 2/5] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner tskd08
2014-08-27 15:29 ` [PATCH v2 3/5] qm1d1c0042: add driver for Sharp QM1D1C0042 ISDB-S tuner tskd08
2014-08-27 15:29 ` [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator tskd08
2014-08-31 10:29 ` Matthias Schwarzott
2014-08-31 13:32 ` Akihiro TSUKADA
2014-08-31 19:48 ` Antti Palosaari [this message]
2014-09-01 9:54 ` Akihiro TSUKADA
2014-09-06 2:02 ` Antti Palosaari
2014-09-06 2:27 ` Mauro Carvalho Chehab
2014-09-06 3:00 ` DVB clock source (Re: [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator) Antti Palosaari
2014-09-06 3:11 ` Mauro Carvalho Chehab
2014-09-06 3:20 ` Antti Palosaari
2014-09-06 6:09 ` [PATCH v2 4/5] tc90522: add driver for Toshiba TC90522 quad demodulator Akihiro TSUKADA
2014-09-06 6:51 ` Antti Palosaari
2014-09-06 19:35 ` Akihiro TSUKADA
2014-09-07 1:05 ` Antti Palosaari
2014-09-06 7:13 ` Antti Palosaari
2014-08-27 15:29 ` [PATCH v2 5/5] pt3: add support for Earthsoft PT3 ISDB-S/T receiver card tskd08
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54037BFE.60606@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=tskd08@gmail.com \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).