From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr1.xs4all.nl ([194.109.24.21]:2411 "EHLO smtp-vbr1.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755776AbaICMIc (ORCPT ); Wed, 3 Sep 2014 08:08:32 -0400 Message-ID: <5407048C.1050601@xs4all.nl> Date: Wed, 03 Sep 2014 14:07:40 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, stoth@kernellabs.com, Hans Verkuil Subject: Re: [PATCHv2 17/20] cx23885: fix weird sizes. References: <1408010045-24016-1-git-send-email-hverkuil@xs4all.nl> <1408010045-24016-18-git-send-email-hverkuil@xs4all.nl> <20140903084624.2cc523b8.m.chehab@samsung.com> In-Reply-To: <20140903084624.2cc523b8.m.chehab@samsung.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/03/14 13:46, Mauro Carvalho Chehab wrote: > Em Thu, 14 Aug 2014 11:54:02 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> These values make no sense. All SDTV standards have the same width. >> This seems to be copied from the cx88 driver. Just drop these weird >> values. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/media/pci/cx23885/cx23885.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/pci/cx23885/cx23885.h b/drivers/media/pci/cx23885/cx23885.h >> index 99a5fe0..f542ced 100644 >> --- a/drivers/media/pci/cx23885/cx23885.h >> +++ b/drivers/media/pci/cx23885/cx23885.h >> @@ -610,15 +610,15 @@ extern int cx23885_risc_databuffer(struct pci_dev *pci, >> >> static inline unsigned int norm_maxw(v4l2_std_id norm) >> { >> - return (norm & (V4L2_STD_MN & ~V4L2_STD_PAL_Nc)) ? 720 : 768; >> + return 720; > > Not sure if you checked cx23885 datasheet. I didn't, but I don't doubt > that it uses about the same A/D logic as cx88. > > In the case of cx88, the sampling rate for a few standards is different, > as recommended at the datasheet. This is done to provide the highest > image quality, as there are some customized filters for some standards, > but they require some specific sampling rates. That's why PAL-Nc and > NTSC/PAL-M are handled on a different way. I will double-check what the datasheet has to say about this. And if there is a good reason for this then I will add a comment at the very least. > >> } >> >> static inline unsigned int norm_maxh(v4l2_std_id norm) >> { >> - return (norm & V4L2_STD_625_50) ? 576 : 480; >> + return (norm & V4L2_STD_525_60) ? 480 : 576; > > This is obviously wrong. What is wrong? The original code or the new code? They are both right. I prefer to use the same standard test everywhere in a driver. That way if the standard is set to STD_ALL the driver will still interpret it the same everywhere instead of as 50 Hz in one case and 60 Hz in another. But it's no big deal. Regards, Hans > >> } >> >> static inline unsigned int norm_swidth(v4l2_std_id norm) >> { >> - return (norm & (V4L2_STD_MN & ~V4L2_STD_PAL_Nc)) ? 754 : 922; >> + return 754; >> } > > Same as above commented. > > Regards, > Mauro > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >