From: Hans Verkuil <hansverk@cisco.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 2/3] [media] tw68: Remove a sparse warning
Date: Thu, 04 Sep 2014 16:54:38 +0200 [thread overview]
Message-ID: <54087D2E.806@cisco.com> (raw)
In-Reply-To: <fafeea3682cc2da98f05138ec4b1c8ebc6798b5d.1409841955.git.m.chehab@samsung.com>
I'll need to review this as well. Perhaps tw_writel should expect a __le32?
Hans
On 09/04/14 16:46, Mauro Carvalho Chehab wrote:
> drivers/media/pci/tw68/tw68-video.c:351:9: warning: incorrect type in argument 1 (different base types)
> drivers/media/pci/tw68/tw68-video.c:351:9: expected unsigned int [unsigned] val
> drivers/media/pci/tw68/tw68-video.c:351:9: got restricted __le32 [usertype] <noident>
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
>
> diff --git a/drivers/media/pci/tw68/tw68-video.c b/drivers/media/pci/tw68/tw68-video.c
> index 66fae2345fdd..4dd38578cf1b 100644
> --- a/drivers/media/pci/tw68/tw68-video.c
> +++ b/drivers/media/pci/tw68/tw68-video.c
> @@ -348,7 +348,7 @@ int tw68_video_start_dma(struct tw68_dev *dev, struct tw68_buf *buf)
> * a new address can be set.
> */
> tw_clearl(TW68_DMAC, TW68_DMAP_EN);
> - tw_writel(TW68_DMAP_SA, cpu_to_le32(buf->dma));
> + tw_writel(TW68_DMAP_SA, (__force u32)cpu_to_le32(buf->dma));
> /* Clear any pending interrupts */
> tw_writel(TW68_INTSTAT, dev->board_virqmask);
> /* Enable the risc engine and the fifo */
>
next prev parent reply other threads:[~2014-09-04 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 14:46 [PATCH 1/3] [media] tw68: make tw68_pci_tbl static and constify Mauro Carvalho Chehab
2014-09-04 14:46 ` [PATCH 2/3] [media] tw68: Remove a sparse warning Mauro Carvalho Chehab
2014-09-04 14:54 ` Hans Verkuil [this message]
2014-09-04 15:05 ` Mauro Carvalho Chehab
2014-09-04 16:20 ` Hans Verkuil
2014-09-04 14:46 ` [PATCH 3/3] [media] tw68: don't assume that pagesize is always 4096 Mauro Carvalho Chehab
2014-09-04 14:53 ` Hans Verkuil
2014-09-04 16:21 ` Hans Verkuil
2014-09-04 14:50 ` [PATCH 1/3] [media] tw68: make tw68_pci_tbl static and constify Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54087D2E.806@cisco.com \
--to=hansverk@cisco.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).