From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:50234 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbaIRMBF (ORCPT ); Thu, 18 Sep 2014 08:01:05 -0400 Message-ID: <541AC97B.1020508@iki.fi> Date: Thu, 18 Sep 2014 15:00:59 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Mauro Carvalho Chehab , Olli Salonen CC: linux-media@vger.kernel.org Subject: Re: [PATCH 1/3] si2157: change command for sleep References: <1408990024-1642-1-git-send-email-olli.salonen@iki.fi> <54097579.6000507@iki.fi> <20140918082233.16ce4a37@recife.lan> <20140918085055.15375d0b@recife.lan> In-Reply-To: <20140918085055.15375d0b@recife.lan> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/18/2014 02:50 PM, Mauro Carvalho Chehab wrote: > Sorry, I misunderstood this patch. > > There are actually two different things, each requiring a different PM > setting: > > 1) to put the tuner to sleep while it is not in usage; > > 2) put the machine to suspend. > > This patch is for (1). That's FINE. I'll apply it. > > Yet, for (2), assuming a suspend to ram, the best is to save more > power. > > In the past, the DVB core didn't make any distinction between those > two, but we recently added a hook for suspend there. > > So, it makes sense to keep the tuner powerdown mode for suspend. I think old deep sleep should be used for suspend, whilst on warm state that new is OK. I2C driver has suspend/resume support and it is one thing I am going to study in near future. Currently I have 128GB SSD and no swap at all, so I cannot test it now. I have already bought 256GB SSD and I am just waiting for Fedora 21 alpha version, which I will install with proper swap. Unfortunately they have delayed many times already Fedora 21 alpha... I am not even sure if DVB frontend needs any special suspend/resume handling, isn't it possible to use standard kernel PM here? (I already added some initial PM to DVB FE ~2 years ago, but IIRC those will only kill threads and so which are not allowed when suspend). So is there some reason DVB FE needs suspend/resume hooks? regards Antti -- http://palosaari.fi/