From: Antti Palosaari <crope@iki.fi>
To: "Luca Olivetti" <luca@ventoso.org>,
"Frank Schäfer" <fschaefer.oss@googlemail.com>,
"Fengguang Wu" <fengguang.wu@intel.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, Jet Chen <jet.chen@intel.com>,
Su Tao <tao.su@intel.com>, Yuanhan Liu <yuanhan.liu@intel.com>,
LKP <lkp@01.org>,
linux-kernel@vger.kernel.org
Subject: Re: [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel)
Date: Sat, 20 Sep 2014 14:18:07 +0300 [thread overview]
Message-ID: <541D626F.9090107@iki.fi> (raw)
In-Reply-To: <541C8A26.6050207@ventoso.org>
Moikka!
On 09/19/2014 10:55 PM, Luca Olivetti wrote:
> El 19/09/14 21:22, Frank Schäfer ha escrit:
>
>>>
>>> So symbol_request() returns pointers.!= NULL
>>>
>>> A closer look at the definition of symbol_request() shows, that it does
>>> nothing if CONFIG_MODULES is disabled (it just returns its argument).
>>>
>>>
>>> One possibility to fix this bug would be to embrace these three lines with
>>>
>>> #ifdef CONFIG_DVB_USB_AF9005_REMOTE
>>> ...
>>> #endif
>> Luca, what do you think ?
>>
>> This seems to be an ancient bug, which is known at least since 5 1/2 years:
>> https://lkml.org/lkml/2009/2/4/350
>
> Well, it's been a while so I don't remember the details, but I think the
> same now as then ;-)
> The idea behind CONFIG_DVB_USB_AF9005_REMOTE was to provide an
> alternative implementation (based on lirc, at the time it wasn't in the
> kernel), since this adapter doesn't decode the IR pulses by itself.
> In theory you could leave it undefined but still provide an
> implementation in a different module. Just adding
>
> #ifdef CONFIG_DVB_USB_AF9005_REMOTE
>
> would nuke the (futile?) effort.
>
> Now, since the problem seems to be with CONFIG_MODULES disabled, maybe
> you could combine both conditions
>
> #if defined(CONFIG_MODULE) || defined(CONFIG_DVB_USB_AF9005_REMOTE)
Proper fix is to remove whole home made IR decider and use common IR
decoders in kernel nowadays... And yes, that is very old driver and at
the time Luca made it there was no IR decoders nor whole remote
controller framework.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-09-20 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140919014124.GA8326@localhost>
2014-09-19 19:01 ` [media/em28xx] BUG: unable to handle kernel Frank Schäfer
2014-09-19 19:22 ` [media/dvb_usb_af9005] BUG: unable to handle kernel paging request (WAS: [media/em28xx] BUG: unable to handle kernel) Frank Schäfer
2014-09-19 19:55 ` Luca Olivetti
2014-09-20 11:18 ` Antti Palosaari [this message]
2014-09-23 18:52 ` Frank Schäfer
2014-09-23 21:03 ` Luca Olivetti
2014-09-25 13:54 ` Frank Schäfer
2014-09-25 15:57 ` Luca Olivetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541D626F.9090107@iki.fi \
--to=crope@iki.fi \
--cc=fengguang.wu@intel.com \
--cc=fschaefer.oss@googlemail.com \
--cc=jet.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@01.org \
--cc=luca@ventoso.org \
--cc=m.chehab@samsung.com \
--cc=tao.su@intel.com \
--cc=yuanhan.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).