From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.gentoo.org ([140.211.166.183]:48091 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbaIWEyP (ORCPT ); Tue, 23 Sep 2014 00:54:15 -0400 Message-ID: <5420FCED.7010400@gentoo.org> Date: Tue, 23 Sep 2014 06:54:05 +0200 From: Matthias Schwarzott MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, crope@iki.fi Subject: Re: [PATCH 7/7] si2165: do load firmware without extra header References: <1409484912-19300-1-git-send-email-zzam@gentoo.org> <1409484912-19300-8-git-send-email-zzam@gentoo.org> <20140922195813.4cec3704@recife.lan> In-Reply-To: <20140922195813.4cec3704@recife.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 23.09.2014 00:58, Mauro Carvalho Chehab wrote: > Em Sun, 31 Aug 2014 13:35:12 +0200 > Matthias Schwarzott escreveu: > >> The new file has a different name: dvb-demod-si2165-D.fw >> >> Count blocks instead of reading count from extra header. >> Calculate CRC during upload and compare result to what chip calcuated. >> Use 0x01 instead of real patch version, because this is only used to >> check if something was uploaded but not to check the version of it. >> >> Signed-off-by: Matthias Schwarzott >> --- > > ... > >> diff --git a/drivers/media/dvb-frontends/si2165_priv.h b/drivers/media/dvb-frontends/si2165_priv.h >> index 2b70cf1..fd778dc 100644 >> --- a/drivers/media/dvb-frontends/si2165_priv.h >> +++ b/drivers/media/dvb-frontends/si2165_priv.h >> @@ -18,6 +18,6 @@ >> #ifndef _DVB_SI2165_PRIV >> #define _DVB_SI2165_PRIV >> >> -#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165.fw" >> +#define SI2165_FIRMWARE_REV_D "dvb-demod-si2165-D.fw" > > Please, don't do that. Changing the name of the firmware and breaking > the format is a bad idea, specially since you're not supporting anymore > the legacy one. > > I would be ok if you were not breaking support for the old firmware > file. > Hmm, there is no kernel yet that contains this driver. And the firmware is identical, just the header is missing. Do I really have to support both then? > Also, better to use lowercase for the firmware name. Ok, I will change the "D" to lower-case. > > PS.: I'm not applying patch 6/7 as this got rejected. Ok, I will resend patch 6 and eventually 7. Regards Matthias