From: Antti Palosaari <crope@iki.fi>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org, Bimow Chen <Bimow.Chen@ite.com.tw>
Subject: Re: Fw: [PATCH 4/4] V4L/DVB: Add sleep for firmware ready
Date: Tue, 23 Sep 2014 15:00:48 +0300 [thread overview]
Message-ID: <542160F0.1000407@iki.fi> (raw)
In-Reply-To: <20140923085039.51765665@recife.lan>
I am not sure as I cannot reproduce it. Also 30ms wait here is long as
hell, whilst it is not critical.
When I look that firmware downloading from the 1-2 month old Hauppauge
driver sniffs, it is not there:
That line is CMD_FW_BOOT, command 0x23 it is 3rd number:
#define CMD_FW_BOOT 0x23
000313: OUT: 000000 ms 001490 ms BULK[00002] >>> 05 00 23 9a 65 dc
Here is whole sequence:
000311: OUT: 000000 ms 001489 ms BULK[00002] >>> 15 00 29 99 03 01 00
01 57 f7 09 02 6d 6c 02 4f 9f 02 4f a2 0b 16
000312: OUT: 000001 ms 001489 ms BULK[00081] <<< 04 99 00 66 ff
000313: OUT: 000000 ms 001490 ms BULK[00002] >>> 05 00 23 9a 65 dc
000314: OUT: 000011 ms 001490 ms BULK[00081] <<< 04 9a 00 65 ff
000315: OUT: 000000 ms 001501 ms BULK[00002] >>> 0b 00 00 9b 01 02 00
00 12 22 40 ec
000316: OUT: 000000 ms 001501 ms BULK[00081] <<< 05 9b 00 02 62 ff
So windows driver waits 10ms after boot, not before.
Due to these reasons, I would like to skip that patch until I see error
or get good explanation why it is needed and so.
regards
Antti
On 09/23/2014 02:50 PM, Mauro Carvalho Chehab wrote:
> Antti,
>
> After the firmware load changes, is this patch still applicable?
>
> Regards,
> Mauro
>
> Forwarded message:
>
> Date: Tue, 05 Aug 2014 13:48:03 +0800
> From: Bimow Chen <Bimow.Chen@ite.com.tw>
> To: linux-media@vger.kernel.org
> Subject: [PATCH 4/4] V4L/DVB: Add sleep for firmware ready
>
>
> From b19fa868ce937a6ef10f1591a49b2a7ad14964a9 Mon Sep 17 00:00:00 2001
> From: Bimow Chen <Bimow.Chen@ite.com.tw>
> Date: Tue, 5 Aug 2014 11:20:53 +0800
> Subject: [PATCH 4/4] Add sleep for firmware ready.
>
>
> Signed-off-by: Bimow Chen <Bimow.Chen@ite.com.tw>
> ---
> drivers/media/usb/dvb-usb-v2/af9035.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/af9035.c b/drivers/media/usb/dvb-usb-v2/af9035.c
> index 7b9b75f..a450cdb 100644
> --- a/drivers/media/usb/dvb-usb-v2/af9035.c
> +++ b/drivers/media/usb/dvb-usb-v2/af9035.c
> @@ -602,6 +602,8 @@ static int af9035_download_firmware(struct dvb_usb_device *d,
> if (ret < 0)
> goto err;
>
> + msleep(30);
> +
> /* firmware loaded, request boot */
> req.cmd = CMD_FW_BOOT;
> ret = af9035_ctrl_msg(d, &req);
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-09-23 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 11:50 Fw: [PATCH 4/4] V4L/DVB: Add sleep for firmware ready Mauro Carvalho Chehab
2014-09-23 12:00 ` Antti Palosaari [this message]
2014-09-23 13:11 ` Mauro Carvalho Chehab
2014-09-24 3:47 ` Bimow.Chen
2014-09-24 19:18 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542160F0.1000407@iki.fi \
--to=crope@iki.fi \
--cc=Bimow.Chen@ite.com.tw \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).