linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	kbuild-all@01.org
Subject: Re: [linuxtv-media:devel-3.17-rc6 491/499] drivers/media/usb/em28xx/em28xx.h:787:2: warning: 'vid' may be used uninitialized in this function
Date: Tue, 23 Sep 2014 20:35:48 +0200	[thread overview]
Message-ID: <5421BD84.8090609@googlemail.com> (raw)
In-Reply-To: <5420da9a.AVbO33MRDo+yIJFy%fengguang.wu@intel.com>


Am 23.09.2014 um 04:27 schrieb kbuild test robot:
> tree:   git://linuxtv.org/media_tree.git devel-3.17-rc6
> head:   7f8de65b0dc84c19e79d7a642a5655524c57035c
> commit: f5ac7a471e156f997833f94bad2228e57122c227 [491/499] [media] em28xx: remove some unnecessary fields from struct em28xx_audio_mode
> config: i386-randconfig-r0-0923 (attached as .config)
> reproduce:
>   git checkout f5ac7a471e156f997833f94bad2228e57122c227
>   # save the attached .config to linux build tree
>   make ARCH=i386 
>
> Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
> http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
>
> All warnings:
>
>    In file included from drivers/media/usb/em28xx/em28xx-core.c:35:0:
>    drivers/media/usb/em28xx/em28xx-core.c: In function 'em28xx_audio_setup':
>>> drivers/media/usb/em28xx/em28xx.h:787:2: warning: 'vid' may be used uninitialized in this function [-Wmaybe-uninitialized]
>      printk(KERN_INFO "%s: "fmt,\
>      ^
>    drivers/media/usb/em28xx/em28xx-core.c:507:6: note: 'vid' was declared here
>      u32 vid;
>          ^
This is a false warning.
Applying https://patchwork.linuxtv.org/patch/25918/ makes it disappear.

Regards,
Frank


> vim +/vid +787 drivers/media/usb/em28xx/em28xx.h
>
> 47677e51 drivers/media/usb/em28xx/em28xx.h   Mauro Carvalho Chehab 2014-03-05  771  void em28xx_free_device(struct kref *ref);
> c8793b03 drivers/media/video/em28xx/em28xx.h Mauro Carvalho Chehab 2008-01-13  772  
> 855ff38e drivers/media/usb/em28xx/em28xx.h   Frank Schaefer        2013-03-27  773  /* Provided by em28xx-camera.c */
> 855ff38e drivers/media/usb/em28xx/em28xx.h   Frank Schaefer        2013-03-27  774  int em28xx_detect_sensor(struct em28xx *dev);
> 855ff38e drivers/media/usb/em28xx/em28xx.h   Frank Schaefer        2013-03-27  775  int em28xx_init_camera(struct em28xx *dev);
> 855ff38e drivers/media/usb/em28xx/em28xx.h   Frank Schaefer        2013-03-27  776  
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  777  /* printk macros */
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  778  
> 3acf2809 drivers/media/video/em28xx/em28xx.h Mauro Carvalho Chehab 2005-11-08  779  #define em28xx_err(fmt, arg...) do {\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  780  	printk(KERN_ERR fmt , ##arg); } while (0)
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  781  
> 3acf2809 drivers/media/video/em28xx/em28xx.h Mauro Carvalho Chehab 2005-11-08  782  #define em28xx_errdev(fmt, arg...) do {\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  783  	printk(KERN_ERR "%s: "fmt,\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  784  			dev->name , ##arg); } while (0)
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  785  
> 3acf2809 drivers/media/video/em28xx/em28xx.h Mauro Carvalho Chehab 2005-11-08  786  #define em28xx_info(fmt, arg...) do {\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08 @787  	printk(KERN_INFO "%s: "fmt,\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  788  			dev->name , ##arg); } while (0)
> 3acf2809 drivers/media/video/em28xx/em28xx.h Mauro Carvalho Chehab 2005-11-08  789  #define em28xx_warn(fmt, arg...) do {\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  790  	printk(KERN_WARNING "%s: "fmt,\
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  791  			dev->name , ##arg); } while (0)
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  792  
> a6c2ba28 drivers/media/video/em28xx/em28xx.h Andrew Morton         2005-11-08  793  #endif
>
> :::::: The code at line 787 was first introduced by commit
> :::::: a6c2ba283565dbc9f055dcb2ecba1971460bb535 [PATCH] v4l: 716: support for em28xx board family
>
> :::::: TO: akpm@osdl.org <akpm@osdl.org>
> :::::: CC: Linus Torvalds <torvalds@g5.osdl.org>
>
> ---
> 0-DAY kernel build testing backend              Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation


      reply	other threads:[~2014-09-23 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  2:27 [linuxtv-media:devel-3.17-rc6 491/499] drivers/media/usb/em28xx/em28xx.h:787:2: warning: 'vid' may be used uninitialized in this function kbuild test robot
2014-09-23 18:35 ` Frank Schäfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5421BD84.8090609@googlemail.com \
    --to=fschaefer.oss@googlemail.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).