Re: [PATCH v4 3/4] tc90522: add driver for Toshiba TC90522 quad demodulator

[Akihiro TSUKADA <tskd08@gmail.com>]

Hi,

On 2014年09月24日 05:07, Mauro Carvalho Chehab wrote:
> I applied this series, as we're discussing it already for a long time,
> and it seems in a good shape...

thanks for your reviews and advices.

>> +static int tc90522s_read_status(struct dvb_frontend *fe, fe_status_t *status)
...........
>> +	if (reg & 0x60) /* carrier? */
>> +		return 0;
> 
> Sure about that? Wouldn't it be, instead, reg & 0x60 == 0x60?

Yes, I'm pretty sure about that.
The register indicates errors in the various demod stages,
and if all go well, the reg should be 0.

>> +static int tc90522t_read_status(struct dvb_frontend *fe, fe_status_t *status)
..............
> The entire series of checks above seems wrong on my eyes too.
> 
> For example, if reg = 0x20 or 0x40 or 0x80 or ..., it will return
> FE_HAS_LOCK.

This register 0x96 should indicates "lock" status for each layers,
and since layer config can vary in ISDB-T, the driver checks that
any of the three bits is set, for faster lock detection.
and the register 0x80 is the same kind of the one in the above ISDB-S case.

> PS.: could you also test (and send us patches as needed) for ISDB-S
> support at libdvbv5 and dvbv5-utils[1]?
I'll have a try.

regards,
akihiro